usb: host: fix callback parameter type

jfischer-no · kartben · commit 3fd7ea980ea8 · 2025-02-10T09:02:45.000+01:00
The parameter should not be a pointer to type usbh_udev_cb_t.

Signed-off-by: Johann Fischer &lt;johann.fischer@nordicsemi.no&gt;
diff --git a/subsys/usb/host/usbh_ch9.c b/subsys/usb/host/usbh_ch9.c
@@ -53,7 +53,7 @@ int usbh_req_setup(struct usb_device *const udev,
 	uint8_t ep = usb_reqtype_is_to_device(&req) ? 0x00 : 0x80;
 	int ret;
 
-	xfer = usbh_xfer_alloc(udev, ep, 0, 64, SETUP_REQ_TIMEOUT, (void *)ch9_req_cb);
+	xfer = usbh_xfer_alloc(udev, ep, 0, 64, SETUP_REQ_TIMEOUT, ch9_req_cb);
 	if (!xfer) {
 		return -ENOMEM;
 	}
diff --git a/subsys/usb/host/usbh_device.h b/subsys/usb/host/usbh_device.h
@@ -44,7 +44,7 @@ static inline struct uhc_transfer *usbh_xfer_alloc(struct usb_device *udev,
 						   const uint8_t attrib,
 						   const uint16_t mps,
 						   const uint16_t timeout,
-						   usbh_udev_cb_t *const cb)
+						   usbh_udev_cb_t cb)
 {
 	struct usbh_contex *const ctx = udev->ctx;
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ int usbh_req_setup(struct usb_device *const udev,`
`53`	`53`	`uint8_t ep = usb_reqtype_is_to_device(&req) ? 0x00 : 0x80;`
`54`	`54`	`int ret;`
`55`	`55`
`56`		`- xfer = usbh_xfer_alloc(udev, ep, 0, 64, SETUP_REQ_TIMEOUT, (void *)ch9_req_cb);`
	`56`	`+ xfer = usbh_xfer_alloc(udev, ep, 0, 64, SETUP_REQ_TIMEOUT, ch9_req_cb);`
`57`	`57`	`if (!xfer) {`
`58`	`58`	`return -ENOMEM;`
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ static inline struct uhc_transfer usbh_xfer_alloc(struct usb_device udev,`
`44`	`44`	`const uint8_t attrib,`
`45`	`45`	`const uint16_t mps,`
`46`	`46`	`const uint16_t timeout,`
`47`		`- usbh_udev_cb_t *const cb)`
	`47`	`+ usbh_udev_cb_t cb)`
`48`	`48`	`{`
`49`	`49`	`struct usbh_contex *const ctx = udev->ctx;`
`50`	`50`