Skip to content

Commit 40823be

Browse files
Raffael Rostagnofabiobaltieri
authored andcommitted
runners: esp32: Fix board arguments
Fix board arguments to properly build runners.yaml and set esp-monitor-baud. Signed-off-by: Raffael Rostagno <[email protected]>
1 parent b85e4f1 commit 40823be

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

boards/common/esp32.board.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ board_runner_args(openocd --gdb-init "thb main")
1313
set(ESP_IDF_PATH ${ZEPHYR_HAL_ESPRESSIF_MODULE_DIR})
1414
assert(ESP_IDF_PATH "ESP_IDF_PATH is not set")
1515

16-
board_finalize_runner_args(esp32 "--esp-idf-path=${ESP_IDF_PATH}")
16+
board_runner_args(esp32 "--esp-idf-path=${ESP_IDF_PATH}")

soc/espressif/common/CMakeLists.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ math(EXPR esptoolpy_flashsize "${CONFIG_FLASH_SIZE} / 0x100000")
1212

1313
# Get UART baudrate from DT
1414
dt_chosen(dts_shell_uart PROPERTY "zephyr,shell-uart")
15-
if(${dts_shell_uart})
15+
if(DEFINED dts_shell_uart AND dts_shell_uart)
1616
dt_prop(monitor_baud PATH ${dts_shell_uart} PROPERTY "current-speed")
1717
endif()
1818

@@ -51,10 +51,10 @@ else()
5151
endif()
5252

5353
dt_reg_addr(image_off PATH ${dts_partition_path})
54-
board_finalize_runner_args(esp32 "--esp-app-address=${image_off}")
55-
board_finalize_runner_args(esp32 "--esp-flash-size=${esptoolpy_flashsize}MB")
56-
board_finalize_runner_args(esp32 "--esp-flash-freq=${CONFIG_ESPTOOLPY_FLASHFREQ}")
57-
board_finalize_runner_args(esp32 "--esp-flash-mode=${CONFIG_ESPTOOLPY_FLASHMODE}")
54+
board_runner_args(esp32 "--esp-app-address=${image_off}")
55+
board_runner_args(esp32 "--esp-flash-size=${esptoolpy_flashsize}MB")
56+
board_runner_args(esp32 "--esp-flash-freq=${CONFIG_ESPTOOLPY_FLASHFREQ}")
57+
board_runner_args(esp32 "--esp-flash-mode=${CONFIG_ESPTOOLPY_FLASHMODE}")
5858
board_finalize_runner_args(esp32 "--esp-monitor-baud=${monitor_baud}")
5959

6060
message("-- Image partition ${dts_partition_path}")

0 commit comments

Comments
 (0)