tests: hwinfo: Make the tests depending on HWINFO_HAS_DRIVER

The test checks for a correct implementation if HWINFO_HAS_DRIVER
is set, otherwise it checks for -ENOTSUP return value.

Signed-off-by: Alexander Wachter <[email protected]>

Author: alexanderwachter

tests/drivers/hwinfo/api/src/main.c

@@ -26,10 +26,7 @@
 #define BUFFER_LENGTH 17
 #define BUFFER_CANARY 0xFF
 
-/*
- * Function invokes the get_entropy callback in driver
- * to get the random data and fill to passed buffer
- */
+#ifdef CONFIG_HWINFO_HAS_DRIVER
 static void test_device_id_get(void)
 {
 	u8_t buffer_1[BUFFER_LENGTH];
@@ -39,7 +36,8 @@ static void test_device_id_get(void)
 
 	length_read_1 = hwinfo_get_device_id(buffer_1, 1);
 	zassert_not_equal(length_read_1, -ENOTSUP, "Not supported by hardware");
-	zassert_false((length_read_1 < 0), "Error returned: %d", length_read_1);
+	zassert_false((length_read_1 < 0),
+		      "Unexpected negative return value: %d", length_read_1);
 	zassert_not_equal(length_read_1, 0, "Zero bytes read");
 	zassert_equal(length_read_1, 1, "Length not adhered");
 
@@ -66,10 +64,34 @@ static void test_device_id_get(void)
 			      "Two consecutively readings don't match");
 	}
 }
+#else
+static void test_device_id_get(void) {}
+#endif /* CONFIG_HWINFO_HAS_DRIVER */
+
+#ifndef CONFIG_HWINFO_HAS_DRIVER
+static void test_device_id_enotsup(void)
+{
+	ssize_t ret;
+	u8_t buffer[1];
+
+	ret = hwinfo_get_device_id(buffer, 1);
+	/* There is no hwinfo driver for this platform, hence the return value
+	 * should be -ENOTSUP
+	 */
+	zassert_equal(ret, -ENOTSUP,
+		      "hwinfo_get_device_id returned % instead of %d",
+		      ret, -ENOTSUP);
+}
+#else
+static void test_device_id_enotsup(void) {}
+#endif /* CONFIG_HWINFO_HAS_DRIVER not defined*/
 
 void test_main(void)
 {
 	ztest_test_suite(hwinfo_device_id_api,
-			 ztest_unit_test(test_device_id_get));
+			 ztest_unit_test(test_device_id_get),
+			 ztest_unit_test(test_device_id_enotsup)
+			);
+
 	ztest_run_test_suite(hwinfo_device_id_api);
 }

tests/drivers/hwinfo/api/testcase.yaml

@@ -1,4 +1,4 @@
 tests:
   drivers.device_id:
     tags: driver
-    depends_on: hwinfo
+    filter: CONFIG_HWINFO