drivers: sensor: st: qdec: remove init struct

Remove the calls to LL_TIM_ENCODER_StructInit and LL_TIM_ENCODER_Init
in the QDEC driver. This avoids calling functions from stm32xxxx_ll_tim.c.
They are replaced by a set of simpler functions from the header file.

Signed-off-by: Guillaume Gautier <[email protected]>

Author: gautierg-st

drivers/sensor/st/qdec_stm32/qdec_stm32.c

@@ -78,11 +78,23 @@ static int qdec_stm32_get(const struct device *dev, enum sensor_channel chan,
 	return 0;
 }
 
+static void qdec_stm32_initialize_channel(const struct device *dev, uint32_t ll_channel)
+{
+	const struct qdec_stm32_dev_cfg *const dev_cfg = dev->config;
+
+	LL_TIM_IC_SetActiveInput(dev_cfg->timer_inst, ll_channel, LL_TIM_ACTIVEINPUT_DIRECTTI);
+	LL_TIM_IC_SetFilter(dev_cfg->timer_inst, ll_channel,
+			    dev_cfg->input_filtering_level * LL_TIM_IC_FILTER_FDIV1_N2);
+	LL_TIM_IC_SetPrescaler(dev_cfg->timer_inst, ll_channel, LL_TIM_ICPSC_DIV1);
+	LL_TIM_IC_SetPolarity(dev_cfg->timer_inst, ll_channel,
+			      dev_cfg->is_input_polarity_inverted ? LL_TIM_IC_POLARITY_FALLING :
+								    LL_TIM_IC_POLARITY_RISING);
+}
+
 static int qdec_stm32_initialize(const struct device *dev)
 {
 	const struct qdec_stm32_dev_cfg *const dev_cfg = dev->config;
 	int retval;
-	LL_TIM_ENCODER_InitTypeDef init_props;
 	uint32_t max_counter_value;
 
 	retval = pinctrl_apply_state(dev_cfg->pin_config, PINCTRL_STATE_DEFAULT);
@@ -108,18 +120,6 @@ static int qdec_stm32_initialize(const struct device *dev)
 		return -EINVAL;
 	}
 
-	LL_TIM_ENCODER_StructInit(&init_props);
-
-	init_props.EncoderMode = dev_cfg->encoder_mode;
-
-	if (dev_cfg->is_input_polarity_inverted) {
-		init_props.IC1Polarity = LL_TIM_IC_POLARITY_FALLING;
-		init_props.IC2Polarity = LL_TIM_IC_POLARITY_FALLING;
-	}
-
-	init_props.IC1Filter = dev_cfg->input_filtering_level * LL_TIM_IC_FILTER_FDIV1_N2;
-	init_props.IC2Filter = dev_cfg->input_filtering_level * LL_TIM_IC_FILTER_FDIV1_N2;
-
 	/* Ensure that the counter will always count up to a multiple of counts_per_revolution */
 	if (IS_TIM_32B_COUNTER_INSTANCE(dev_cfg->timer_inst)) {
 		max_counter_value = UINT32_MAX - (UINT32_MAX % dev_cfg->counts_per_revolution) - 1;
@@ -128,10 +128,12 @@ static int qdec_stm32_initialize(const struct device *dev)
 	}
 	LL_TIM_SetAutoReload(dev_cfg->timer_inst, max_counter_value);
 
-	if (LL_TIM_ENCODER_Init(dev_cfg->timer_inst, &init_props) != SUCCESS) {
-		LOG_ERR("Initalization failed");
-		return -EIO;
-	}
+	LL_TIM_SetClockSource(dev_cfg->timer_inst, dev_cfg->encoder_mode);
+
+	qdec_stm32_initialize_channel(dev, LL_TIM_CHANNEL_CH1);
+	qdec_stm32_initialize_channel(dev, LL_TIM_CHANNEL_CH2);
+
+	LL_TIM_CC_EnableChannel(dev_cfg->timer_inst, LL_TIM_CHANNEL_CH1 | LL_TIM_CHANNEL_CH2);
 
 	LL_TIM_EnableCounter(dev_cfg->timer_inst);