Skip to content

Commit 47896e4

Browse files
Abramo-Bagnaranashif
authored andcommitted
coding guidelines: comply with MISRA C:2012 Rule 12.2
- explicit with a cast the destination bitwidth of left shift ensuring to not break DTS Signed-off-by: Abramo Bagnara <[email protected]>
1 parent 32af724 commit 47896e4

File tree

1 file changed

+7
-1
lines changed
  • include/zephyr/dt-bindings/pcie

1 file changed

+7
-1
lines changed

include/zephyr/dt-bindings/pcie/pcie.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,15 @@
2626
#define PCIE_ID_DEV_SHIFT 16U
2727
#define PCIE_ID_DEV_MASK 0xFFFFU
2828

29+
#ifdef __DTS__
30+
#define CAST(type, v) (v)
31+
#else
32+
#define CAST(type, v) ((type)(v))
33+
#endif
34+
2935
#define PCIE_ID(vend, dev) \
3036
((((vend) & PCIE_ID_VEND_MASK) << PCIE_ID_VEND_SHIFT) | \
31-
(((dev) & PCIE_ID_DEV_MASK) << PCIE_ID_DEV_SHIFT))
37+
(CAST(uint32_t, (dev) & PCIE_ID_DEV_MASK) << PCIE_ID_DEV_SHIFT))
3238

3339
#define PCIE_ID_TO_VEND(id) (((id) >> PCIE_ID_VEND_SHIFT) & PCIE_ID_VEND_MASK)
3440
#define PCIE_ID_TO_DEV(id) (((id) >> PCIE_ID_DEV_SHIFT) & PCIE_ID_DEV_MASK)

0 commit comments

Comments
 (0)