Skip to content

Commit 4882849

Browse files
Johan Hedbergjhedberg
authored andcommitted
Bluetooth: controller: Convert benign BT_WARN() messages to BT_DBG()
BT_WARN() should only be used for log messages that may indicate a problem. However, the controller HCI code was using it for messages that were of a pure debugging/informational nature. Convert these to BT_DBG() instead - this should hopefully also help avoid unnecessary user questions of seemingly alarming log messages. Signed-off-by: Johan Hedberg <[email protected]>
1 parent 3fe9883 commit 4882849

File tree

1 file changed

+9
-9
lines changed
  • subsys/bluetooth/controller/hci

1 file changed

+9
-9
lines changed

subsys/bluetooth/controller/hci/hci.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2596,8 +2596,8 @@ static void le_adv_ext_report(struct pdu_data *pdu_data, u8_t *b,
25962596
rssi = -b[offsetof(struct node_rx_pdu, pdu) +
25972597
offsetof(struct pdu_adv, payload) + adv->len];
25982598

2599-
BT_WARN("phy= 0x%x, type= 0x%x, len= %u, tat= %u, rat= %u, rssi=%d dB",
2600-
phy, adv->type, adv->len, adv->tx_addr, adv->rx_addr, rssi);
2599+
BT_DBG("phy= 0x%x, type= 0x%x, len= %u, tat= %u, rat= %u, rssi=%d dB",
2600+
phy, adv->type, adv->len, adv->tx_addr, adv->rx_addr, rssi);
26012601

26022602
if ((adv->type == PDU_ADV_TYPE_EXT_IND) && adv->len) {
26032603
struct pdu_adv_com_ext_adv *p;
@@ -2608,8 +2608,8 @@ static void le_adv_ext_report(struct pdu_data *pdu_data, u8_t *b,
26082608
h = (void *)p->ext_hdr_adi_adv_data;
26092609
ptr = (u8_t *)h + sizeof(*h);
26102610

2611-
BT_WARN("Ext. adv mode= 0x%x, hdr len= %u", p->adv_mode,
2612-
p->ext_hdr_len);
2611+
BT_DBG("Ext. adv mode= 0x%x, hdr len= %u", p->adv_mode,
2612+
p->ext_hdr_len);
26132613

26142614
if (!p->ext_hdr_len) {
26152615
goto no_ext_hdr;
@@ -2625,7 +2625,7 @@ static void le_adv_ext_report(struct pdu_data *pdu_data, u8_t *b,
26252625

26262626
bt_addr_le_to_str(&addr, addr_str, sizeof(addr_str));
26272627

2628-
BT_WARN("AdvA: %s", addr_str);
2628+
BT_DBG("AdvA: %s", addr_str);
26292629

26302630
}
26312631

@@ -2635,7 +2635,7 @@ static void le_adv_ext_report(struct pdu_data *pdu_data, u8_t *b,
26352635
tx_pwr = *(s8_t *)ptr;
26362636
ptr++;
26372637

2638-
BT_WARN("Tx pwr= %d dB", tx_pwr);
2638+
BT_DBG("Tx pwr= %d dB", tx_pwr);
26392639
}
26402640

26412641
/* TODO: length check? */
@@ -2685,8 +2685,8 @@ static void le_scan_req_received(struct pdu_data *pdu_data, u8_t *b,
26852685

26862686
bt_addr_le_to_str(&addr, addr_str, sizeof(addr_str));
26872687

2688-
BT_WARN("handle: %d, addr: %s, rssi: %d dB.",
2689-
handle, addr_str, rssi);
2688+
BT_DBG("handle: %d, addr: %s, rssi: %d dB.",
2689+
handle, addr_str, rssi);
26902690

26912691
return;
26922692
}
@@ -2886,7 +2886,7 @@ static void le_chan_sel_algo(struct pdu_data *pdu_data, u16_t handle,
28862886

28872887
if (!(event_mask & BT_EVT_MASK_LE_META_EVENT) ||
28882888
!(le_event_mask & BT_EVT_MASK_LE_CHAN_SEL_ALGO)) {
2889-
BT_WARN("handle: 0x%04x, CSA: %x.", handle, cs->csa);
2889+
BT_DBG("handle: 0x%04x, CSA: %x.", handle, cs->csa);
28902890
return;
28912891
}
28922892

0 commit comments

Comments
 (0)