drivers: bluetooth: hci_nxp_setup: Prevent re-init of CRC table.

bas-archembedded · henrikbrixandersen · commit 4a09047b0eda · 2025-08-02T13:17:58.000+02:00
The CRC32 table only needs to be generated once, so prevent it from
regenerating every time as it only required once.

Signed-off-by: Bas van Loon &lt;bas@arch-embedded.com&gt;
diff --git a/drivers/bluetooth/hci/hci_nxp_setup.c b/drivers/bluetooth/hci/hci_nxp_setup.c
@@ -77,6 +77,10 @@ static void fw_upload_gen_crc32_table(void)
 	int i, j;
 	unsigned long crc_accum;
 
+	if (made_table) {
+		return;
+	}
+
 	for (i = 0; i < 256; i++) {
 		crc_accum = ((unsigned long)i << 24);
 		for (j = 0; j < 8; j++) {
@@ -88,6 +92,9 @@ static void fw_upload_gen_crc32_table(void)
 		}
 		crc_table[i] = crc_accum;
 	}
+
+	/* Mark CRC32 table generation complete */
+	made_table = true;
 }
 
 static unsigned char fw_upload_crc8(unsigned char *array, unsigned char len)

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,10 @@ static void fw_upload_gen_crc32_table(void)`
`77`	`77`	`int i, j;`
`78`	`78`	`unsigned long crc_accum;`
`79`	`79`
	`80`	`+ if (made_table) {`
	`81`	`+ return;`
	`82`	`+ }`
	`83`	`+`
`80`	`84`	`for (i = 0; i < 256; i++) {`
`81`	`85`	`crc_accum = ((unsigned long)i << 24);`
`82`	`86`	`for (j = 0; j < 8; j++) {`
`@@ -88,6 +92,9 @@ static void fw_upload_gen_crc32_table(void)`
`88`	`92`	`}`
`89`	`93`	`crc_table[i] = crc_accum;`
`90`	`94`	`}`
	`95`	`+`
	`96`	`+ /* Mark CRC32 table generation complete */`
	`97`	`+ made_table = true;`
`91`	`98`	`}`
`92`	`99`
`93`	`100`	`static unsigned char fw_upload_crc8(unsigned char *array, unsigned char len)`