drivers: pcie: Remove magic number

finikorg · fabiobaltieri · commit 4a1744663647 · 2023-12-28T12:07:30.000Z
Use definitions instead of magic numbers.

Signed-off-by: Andrei Emeltchenko &lt;andrei.emeltchenko@intel.com&gt;
diff --git a/drivers/pcie/host/pcie.c b/drivers/pcie/host/pcie.c
@@ -159,7 +159,8 @@ static bool pcie_get_bar(pcie_bdf_t bdf,
 	}
 
 	/* IO/memory decode should be disabled before sizing/update BAR. */
-	pcie_conf_write(bdf, PCIE_CONF_CMDSTAT, cmd_reg & (~0x3));
+	pcie_conf_write(bdf, PCIE_CONF_CMDSTAT,
+			cmd_reg & (~(PCIE_CONF_CMDSTAT_IO | PCIE_CONF_CMDSTAT_MEM)));
 
 	pcie_conf_write(bdf, reg, 0xFFFFFFFFU);
 	size = pcie_conf_read(bdf, reg);

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,8 @@ static bool pcie_get_bar(pcie_bdf_t bdf,`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`/* IO/memory decode should be disabled before sizing/update BAR. */`
`162`		`- pcie_conf_write(bdf, PCIE_CONF_CMDSTAT, cmd_reg & (~0x3));`
	`162`	`+ pcie_conf_write(bdf, PCIE_CONF_CMDSTAT,`
	`163`	`+ cmd_reg & (~(PCIE_CONF_CMDSTAT_IO \| PCIE_CONF_CMDSTAT_MEM)));`
`163`	`164`
`164`	`165`	`pcie_conf_write(bdf, reg, 0xFFFFFFFFU);`
`165`	`166`	`size = pcie_conf_read(bdf, reg);`