Skip to content

Commit 4a875c0

Browse files
erwangojhedberg
authored andcommitted
drivers: ethernet: stm32n6: Fix phy modes declarations
Phy modes declarations where not correctly placed for use with N6 series. Signed-off-by: Erwan Gouriou <[email protected]>
1 parent 727c15a commit 4a875c0

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

drivers/ethernet/eth_stm32_hal_priv.h

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -44,18 +44,6 @@ extern const struct device *eth_stm32_phy_dev;
4444
#define __eth_stm32_buf __aligned(4)
4545
#endif
4646

47-
#if DT_HAS_COMPAT_STATUS_OKAY(st_stm32n6_ethernet)
48-
#define STM32_ETH_PHY_MODE(inst) \
49-
((DT_INST_ENUM_HAS_VALUE(inst, phy_connection_type, rgmii) ? ETH_RGMII_MODE : \
50-
(DT_INST_ENUM_HAS_VALUE(inst, phy_connection_type, gmii) ? ETH_GMII_MODE : \
51-
(DT_INST_ENUM_HAS_VALUE(inst, phy_connection_type, mii) ? ETH_MII_MODE : \
52-
ETH_RMII_MODE))))
53-
#else
54-
#define STM32_ETH_PHY_MODE(inst) \
55-
(DT_INST_ENUM_HAS_VALUE(inst, phy_connection_type, mii) ? \
56-
ETH_MII_MODE : ETH_RMII_MODE)
57-
#endif
58-
5947
#if defined(CONFIG_ETH_STM32_HAL_API_V1)
6048

6149
#define ETH_MII_MODE ETH_MEDIA_INTERFACE_MII
@@ -77,6 +65,22 @@ struct eth_stm32_tx_context {
7765

7866
#endif /* CONFIG_ETH_STM32_HAL_API_V2 */
7967

68+
#if DT_HAS_COMPAT_STATUS_OKAY(st_stm32n6_ethernet)
69+
70+
#define ETH_GMII_MODE HAL_ETH_GMII_MODE
71+
#define ETH_RGMII_MODE HAL_ETH_RGMII_MODE
72+
73+
#define STM32_ETH_PHY_MODE(inst) \
74+
((DT_INST_ENUM_HAS_VALUE(inst, phy_connection_type, rgmii) ? ETH_RGMII_MODE : \
75+
(DT_INST_ENUM_HAS_VALUE(inst, phy_connection_type, gmii) ? ETH_GMII_MODE : \
76+
(DT_INST_ENUM_HAS_VALUE(inst, phy_connection_type, mii) ? ETH_MII_MODE : \
77+
ETH_RMII_MODE))))
78+
#else
79+
#define STM32_ETH_PHY_MODE(inst) \
80+
(DT_INST_ENUM_HAS_VALUE(inst, phy_connection_type, mii) ? \
81+
ETH_MII_MODE : ETH_RMII_MODE)
82+
#endif
83+
8084
/* Definition of the Ethernet driver buffers size and count */
8185
#define ETH_STM32_RX_BUF_SIZE ETH_MAX_PACKET_SIZE /* buffer size for receive */
8286
#define ETH_STM32_TX_BUF_SIZE ETH_MAX_PACKET_SIZE /* buffer size for transmit */

drivers/ethernet/eth_stm32_hal_v2.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@
1919

2020
LOG_MODULE_DECLARE(eth_stm32_hal, CONFIG_ETHERNET_LOG_LEVEL);
2121

22-
#if DT_HAS_COMPAT_STATUS_OKAY(st_stm32n6_ethernet)
23-
#define ETH_GMII_MODE HAL_ETH_GMII_MODE
24-
#define ETH_RGMII_MODE HAL_ETH_RGMII_MODE
25-
#endif
26-
2722
#define ETH_DMA_TX_TIMEOUT_MS 20U /* transmit timeout in milliseconds */
2823

2924
struct eth_stm32_rx_buffer_header {

0 commit comments

Comments
 (0)