Skip to content

Commit 4d777b4

Browse files
Guillaume Lagercarlescufi
authored andcommitted
drivers: modem: Fix loop variables type
int was used regardless of the type used in the end-loop condition Signed-off-by: Guillaume Lager <[email protected]>
1 parent 8f444e4 commit 4d777b4

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

drivers/modem/modem_cmd_handler.c

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@ static int parse_params(struct modem_cmd_handler_data *data, size_t match_len,
110110
const struct modem_cmd *cmd,
111111
uint8_t **argv, size_t argv_len, uint16_t *argc)
112112
{
113-
int i, count = 0;
114-
size_t begin, end;
113+
int count = 0;
114+
size_t begin, end, i;
115115

116116
if (!data || !data->match_buf || !match_len || !cmd || !argv || !argc) {
117117
return -EINVAL;
@@ -215,7 +215,8 @@ static int process_cmd(const struct modem_cmd *cmd, size_t match_len,
215215
static const struct modem_cmd *find_cmd_match(
216216
struct modem_cmd_handler_data *data)
217217
{
218-
int j, i;
218+
int j;
219+
size_t i;
219220

220221
for (j = 0; j < ARRAY_SIZE(data->cmds); j++) {
221222
if (!data->cmds[j] || data->cmds_len[j] == 0U) {
@@ -238,7 +239,7 @@ static const struct modem_cmd *find_cmd_match(
238239
static const struct modem_cmd *find_cmd_direct_match(
239240
struct modem_cmd_handler_data *data)
240241
{
241-
int j, i;
242+
size_t j, i;
242243

243244
for (j = 0; j < ARRAY_SIZE(data->cmds); j++) {
244245
if (!data->cmds[j] || data->cmds_len[j] == 0U) {
@@ -551,7 +552,8 @@ int modem_cmd_handler_setup_cmds(struct modem_iface *iface,
551552
const struct setup_cmd *cmds, size_t cmds_len,
552553
struct k_sem *sem, k_timeout_t timeout)
553554
{
554-
int ret = 0, i;
555+
int ret = 0;
556+
size_t i;
555557

556558
for (i = 0; i < cmds_len; i++) {
557559
if (i) {
@@ -586,7 +588,8 @@ int modem_cmd_handler_setup_cmds_nolock(struct modem_iface *iface,
586588
size_t cmds_len, struct k_sem *sem,
587589
k_timeout_t timeout)
588590
{
589-
int ret = 0, i;
591+
int ret = 0;
592+
size_t i;
590593

591594
for (i = 0; i < cmds_len; i++) {
592595
if (i) {

drivers/modem/modem_pin.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ int modem_pin_config(struct modem_context *ctx, uint32_t pin, bool enable)
5050

5151
int modem_pin_init(struct modem_context *ctx)
5252
{
53-
int i, ret;
53+
int ret;
54+
size_t i;
5455

5556
/* setup port devices and pin directions */
5657
for (i = 0; i < ctx->pins_len; i++) {

0 commit comments

Comments
 (0)