drivers: i2s: nrfx: fix incorrect direction check

gmarull · gmarull · commit 4ec229f74170 · 2021-08-26T09:52:03.000+02:00
I2S direction was not checked correctly in the i2s_nrfx_configure
function.

This patch also fixes coverity issue 238365.

Signed-off-by: Gerard Marull-Paretas &lt;gerard.marull@nordicsemi.no&gt;
diff --git a/drivers/i2s/i2s_nrfx.c b/drivers/i2s/i2s_nrfx.c
@@ -399,11 +399,11 @@ static int i2s_nrfx_configure(const struct device *dev, enum i2s_dir dir,
 
 	if (i2s_cfg->frame_clk_freq == 0) { /* -> reset state */
 		purge_queue(dev, dir);
-		if (dir == I2S_DIR_TX || I2S_DIR_BOTH) {
+		if (dir == I2S_DIR_TX || dir == I2S_DIR_BOTH) {
 			drv_data->tx_configured = false;
 			memset(&drv_data->tx, 0, sizeof(drv_data->tx));
 		}
-		if (dir == I2S_DIR_RX || I2S_DIR_BOTH) {
+		if (dir == I2S_DIR_RX || dir == I2S_DIR_BOTH) {
 			drv_data->rx_configured = false;
 			memset(&drv_data->rx, 0, sizeof(drv_data->rx));
 		}

Original file line number	Diff line number	Diff line change
`@@ -399,11 +399,11 @@ static int i2s_nrfx_configure(const struct device *dev, enum i2s_dir dir,`
`399`	`399`
`400`	`400`	`if (i2s_cfg->frame_clk_freq == 0) { /* -> reset state */`
`401`	`401`	`purge_queue(dev, dir);`
`402`		`- if (dir == I2S_DIR_TX \|\| I2S_DIR_BOTH) {`
	`402`	`+ if (dir == I2S_DIR_TX \|\| dir == I2S_DIR_BOTH) {`
`403`	`403`	`drv_data->tx_configured = false;`
`404`	`404`	`memset(&drv_data->tx, 0, sizeof(drv_data->tx));`
`405`	`405`	`}`
`406`		`- if (dir == I2S_DIR_RX \|\| I2S_DIR_BOTH) {`
	`406`	`+ if (dir == I2S_DIR_RX \|\| dir == I2S_DIR_BOTH) {`
`407`	`407`	`drv_data->rx_configured = false;`
`408`	`408`	`memset(&drv_data->rx, 0, sizeof(drv_data->rx));`
`409`	`409`	`}`