Skip to content

Commit 4ef13f7

Browse files
carlocaionecarlescufi
authored andcommitted
ipc_service: static_vrings: Set WQ priority back to PRIO_PREEMPT
This reverts commit 7f51907. The problem with setting the priority at the highest priority possible is that when the IPC is under high traffic, the WQ could starve the scheduler. Move back to a more sane preemptive priority as default value. Signed-off-by: Carlo Caione <[email protected]>
1 parent b27bf92 commit 4ef13f7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

dts/bindings/ipc/zephyr,ipc-openamp-static-vrings.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ properties:
4242
or for K_PRIO_PREEMPT(2)
4343
priority = <2 PRIO_PREEMPT>;
4444
45-
When this property is missing a default priority of <0 PRIO_COOP> is
45+
When this property is missing a default priority of <0 PRIO_PREEMPT> is
4646
assumed.
4747
4848
zephyr,buffer-size:

subsys/ipc/ipc_service/backends/ipc_rpmsg_static_vrings.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ static int backend_init(const struct device *instance)
623623
(0)), \
624624
.wq_prio_type = COND_CODE_1(DT_INST_NODE_HAS_PROP(i, zephyr_priority), \
625625
(DT_INST_PROP_BY_IDX(i, zephyr_priority, 1)), \
626-
(PRIO_COOP)), \
626+
(PRIO_PREEMPT)), \
627627
.buffer_size = DT_INST_PROP_OR(i, zephyr_buffer_size, \
628628
RPMSG_BUFFER_SIZE), \
629629
.id = i, \

0 commit comments

Comments
 (0)