Skip to content

Commit 55457ee

Browse files
jukkarnashif
authored andcommitted
net: zperf: Change old code to pass compliance checker
Compliance checker complains TYPO_SPELLING: 'in in' may be misspelled - perhaps 'is in'? for code like this static struct net_sockaddr_in in_addr_my = { so change the variable to ipv4_addr_my. Similar change is done for IPv6 variables for consistency. Signed-off-by: Jukka Rissanen <[email protected]>
1 parent b626c83 commit 55457ee

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

subsys/net/lib/zperf/zperf_common.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,24 @@ LOG_MODULE_REGISTER(net_zperf, CONFIG_NET_ZPERF_LOG_LEVEL);
2121

2222
#include "ipv6.h" /* to get infinite lifetime */
2323

24-
static struct net_sockaddr_in6 in6_addr_my = {
24+
static struct net_sockaddr_in6 ipv6_addr_my = {
2525
.sin6_family = NET_AF_INET6,
2626
.sin6_port = net_htons(MY_SRC_PORT),
2727
};
2828

29-
static struct net_sockaddr_in in4_addr_my = {
29+
static struct net_sockaddr_in ipv4_addr_my = {
3030
.sin_family = NET_AF_INET,
3131
.sin_port = net_htons(MY_SRC_PORT),
3232
};
3333

3434
struct net_sockaddr_in6 *zperf_get_sin6(void)
3535
{
36-
return &in6_addr_my;
36+
return &ipv6_addr_my;
3737
}
3838

3939
struct net_sockaddr_in *zperf_get_sin(void)
4040
{
41-
return &in4_addr_my;
41+
return &ipv4_addr_my;
4242
}
4343

4444
#define ZPERF_WORK_Q_THREAD_PRIORITY \

subsys/net/lib/zperf/zperf_shell.c

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -49,22 +49,22 @@ static const char *CONFIG =
4949
#endif
5050
"";
5151

52-
static struct net_sockaddr_in6 in6_addr_my = {
52+
static struct net_sockaddr_in6 ipv6_addr_my = {
5353
.sin6_family = NET_AF_INET6,
5454
.sin6_port = net_htons(MY_SRC_PORT),
5555
};
5656

57-
static struct net_sockaddr_in6 in6_addr_dst = {
57+
static struct net_sockaddr_in6 ipv6_addr_dst = {
5858
.sin6_family = NET_AF_INET6,
5959
.sin6_port = net_htons(DEF_PORT),
6060
};
6161

62-
static struct net_sockaddr_in in4_addr_dst = {
62+
static struct net_sockaddr_in ipv4_addr_dst = {
6363
.sin_family = NET_AF_INET,
6464
.sin_port = net_htons(DEF_PORT),
6565
};
6666

67-
static struct net_sockaddr_in in4_addr_my = {
67+
static struct net_sockaddr_in ipv4_addr_my = {
6868
.sin_family = NET_AF_INET,
6969
.sin_port = net_htons(MY_SRC_PORT),
7070
};
@@ -1365,29 +1365,29 @@ static int shell_cmd_upload2(const struct shell *sh, size_t argc,
13651365
family = !strcmp(argv[start + 1], "v4") ? NET_AF_INET : NET_AF_INET6;
13661366

13671367
if (family == NET_AF_INET6) {
1368-
if (net_ipv6_is_addr_unspecified(&in6_addr_dst.sin6_addr)) {
1368+
if (net_ipv6_is_addr_unspecified(&ipv6_addr_dst.sin6_addr)) {
13691369
shell_fprintf(sh, SHELL_WARNING,
13701370
"Invalid destination IPv6 address.\n");
13711371
return -ENOEXEC;
13721372
}
13731373

13741374
shell_fprintf(sh, SHELL_NORMAL,
13751375
"Connecting to %s\n",
1376-
net_sprint_ipv6_addr(&in6_addr_dst.sin6_addr));
1376+
net_sprint_ipv6_addr(&ipv6_addr_dst.sin6_addr));
13771377

1378-
memcpy(&param.peer_addr, &in6_addr_dst, sizeof(in6_addr_dst));
1378+
memcpy(&param.peer_addr, &ipv6_addr_dst, sizeof(ipv6_addr_dst));
13791379
} else {
1380-
if (net_ipv4_is_addr_unspecified(&in4_addr_dst.sin_addr)) {
1380+
if (net_ipv4_is_addr_unspecified(&ipv4_addr_dst.sin_addr)) {
13811381
shell_fprintf(sh, SHELL_WARNING,
13821382
"Invalid destination IPv4 address.\n");
13831383
return -ENOEXEC;
13841384
}
13851385

13861386
shell_fprintf(sh, SHELL_NORMAL,
13871387
"Connecting to %s\n",
1388-
net_sprint_ipv4_addr(&in4_addr_dst.sin_addr));
1388+
net_sprint_ipv4_addr(&ipv4_addr_dst.sin_addr));
13891389

1390-
memcpy(&param.peer_addr, &in4_addr_dst, sizeof(in4_addr_dst));
1390+
memcpy(&param.peer_addr, &ipv4_addr_dst, sizeof(ipv4_addr_dst));
13911391
}
13921392

13931393
if (argc > 2) {
@@ -1852,47 +1852,47 @@ void zperf_shell_init(void)
18521852

18531853
if (IS_ENABLED(MY_IP6ADDR_SET) && MY_IP6ADDR) {
18541854
ret = net_addr_pton(NET_AF_INET6, MY_IP6ADDR,
1855-
&in6_addr_my.sin6_addr);
1855+
&ipv6_addr_my.sin6_addr);
18561856
if (ret < 0) {
18571857
NET_WARN("Unable to set %s address\n", "IPv6");
18581858
} else {
18591859
NET_INFO("Setting IP address %s",
1860-
net_sprint_ipv6_addr(&in6_addr_my.sin6_addr));
1860+
net_sprint_ipv6_addr(&ipv6_addr_my.sin6_addr));
18611861
}
18621862

18631863
ret = net_addr_pton(NET_AF_INET6, DST_IP6ADDR,
1864-
&in6_addr_dst.sin6_addr);
1864+
&ipv6_addr_dst.sin6_addr);
18651865
if (ret < 0) {
18661866
NET_WARN("Unable to set destination %s address %s",
18671867
"IPv6",
18681868
DST_IP6ADDR ? DST_IP6ADDR
18691869
: "(not set)");
18701870
} else {
18711871
NET_INFO("Setting destination IP address %s",
1872-
net_sprint_ipv6_addr(&in6_addr_dst.sin6_addr));
1872+
net_sprint_ipv6_addr(&ipv6_addr_dst.sin6_addr));
18731873
}
18741874
}
18751875

18761876
if (IS_ENABLED(MY_IP4ADDR_SET) && MY_IP4ADDR) {
18771877
ret = net_addr_pton(NET_AF_INET, MY_IP4ADDR,
1878-
&in4_addr_my.sin_addr);
1878+
&ipv4_addr_my.sin_addr);
18791879
if (ret < 0) {
18801880
NET_WARN("Unable to set %s address\n", "IPv4");
18811881
} else {
18821882
NET_INFO("Setting IP address %s",
1883-
net_sprint_ipv4_addr(&in4_addr_my.sin_addr));
1883+
net_sprint_ipv4_addr(&ipv4_addr_my.sin_addr));
18841884
}
18851885

18861886
ret = net_addr_pton(NET_AF_INET, DST_IP4ADDR,
1887-
&in4_addr_dst.sin_addr);
1887+
&ipv4_addr_dst.sin_addr);
18881888
if (ret < 0) {
18891889
NET_WARN("Unable to set destination %s address %s",
18901890
"IPv4",
18911891
DST_IP4ADDR ? DST_IP4ADDR
18921892
: "(not set)");
18931893
} else {
18941894
NET_INFO("Setting destination IP address %s",
1895-
net_sprint_ipv4_addr(&in4_addr_dst.sin_addr));
1895+
net_sprint_ipv4_addr(&ipv4_addr_dst.sin_addr));
18961896
}
18971897
}
18981898
}

0 commit comments

Comments
 (0)