Skip to content

Commit 55de1c9

Browse files
kuligakartben
authored andcommitted
drivers: auxdisplay: hd44780: get rid of excessive delays
Express delay values in nanoseconds. Set the default delay time values as specified in the HD44780 reference manual. Signed-off-by: Jan Kuliga <[email protected]>
1 parent 537182a commit 55de1c9

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

drivers/auxdisplay/auxdisplay_hd44780.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ static void hd44780_pulse_enable_line(const struct device *dev)
8282
const struct auxdisplay_hd44780_config *const config = dev->config;
8383

8484
gpio_pin_set_dt(&config->e_gpio, 1);
85-
k_sleep(K_USEC(config->enable_line_rise_delay));
85+
k_sleep(K_NSEC(config->enable_line_rise_delay));
8686
gpio_pin_set_dt(&config->e_gpio, 0);
87-
k_sleep(K_USEC(config->enable_line_fall_delay));
87+
k_sleep(K_NSEC(config->enable_line_fall_delay));
8888
}
8989

9090
static void auxdisplay_hd44780_command(const struct device *dev, bool rs, uint8_t cmd,
@@ -567,8 +567,8 @@ static const struct auxdisplay_driver_api auxdisplay_hd44780_auxdisplay_api = {
567567
.line_addresses[2] = DT_INST_PROP_BY_IDX(inst, line_addresses, 2), \
568568
.line_addresses[3] = DT_INST_PROP_BY_IDX(inst, line_addresses, 3), \
569569
.backlight_gpio = GPIO_DT_SPEC_INST_GET_OR(inst, backlight_gpios, {0}), \
570-
.enable_line_rise_delay = DT_INST_PROP(inst, enable_line_rise_delay_us), \
571-
.enable_line_fall_delay = DT_INST_PROP(inst, enable_line_fall_delay_us), \
570+
.enable_line_rise_delay = DT_INST_PROP(inst, enable_line_rise_delay_ns), \
571+
.enable_line_fall_delay = DT_INST_PROP(inst, enable_line_fall_delay_ns), \
572572
.clear_delay = DT_INST_PROP(inst, clear_command_delay_us), \
573573
.boot_delay = DT_INST_PROP(inst, boot_delay_ms), \
574574
}; \

dts/bindings/auxdisplay/hit,hd44780.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,18 +56,18 @@ properties:
5656
Array of addresses for each row, will use defaults if not provided.
5757
Default is as per Hitachi HD44780 specification.
5858
59-
enable-line-rise-delay-us:
59+
enable-line-rise-delay-ns:
6060
type: int
61-
default: 800
61+
default: 450
6262
description: |
63-
Delay time (in us) to wait after enable line rises before setting low.
63+
Delay time (in ns) to wait after enable line rises before setting low.
6464
Default is as per Hitachi HD44780 specification.
6565
66-
enable-line-fall-delay-us:
66+
enable-line-fall-delay-ns:
6767
type: int
68-
default: 100
68+
default: 550
6969
description: |
70-
Delay time (in us) to wait after enable line falls before sending
70+
Delay time (in ns) to wait after enable line falls before sending
7171
another command. Default is as per Hitachi HD44780 specification.
7272
7373
clear-command-delay-us:

0 commit comments

Comments
 (0)