bluetooth: h5: Fix memory access error

LuoZhongYao · jhedberg · commit 5758a9e1c6af · 2019-12-09T17:04:24.000+02:00
According to the context information, the processing of
net_buf_add_u8 within the get_evt_buf function is
redundant and incorrect.

Signed-off-by: ZhongYao Luo &lt;LuoZhongYao@gmail.com&gt;
diff --git a/drivers/bluetooth/hci/h5.c b/drivers/bluetooth/hci/h5.c
@@ -406,14 +406,7 @@ static void h5_process_complete_packet(u8_t *hdr)
 
 static inline struct net_buf *get_evt_buf(u8_t evt)
 {
-	struct net_buf *buf;
-
-	buf = bt_buf_get_evt(evt, false, K_NO_WAIT);
-	if (buf) {
-		net_buf_add_u8(h5.rx_buf, evt);
-	}
-
-	return buf;
+	return bt_buf_get_evt(evt, false, K_NO_WAIT);
 }
 
 static void bt_uart_isr(struct device *unused)

Original file line number	Diff line number	Diff line change
`@@ -406,14 +406,7 @@ static void h5_process_complete_packet(u8_t *hdr)`
`406`	`406`
`407`	`407`	`static inline struct net_buf *get_evt_buf(u8_t evt)`
`408`	`408`	`{`
`409`		`- struct net_buf *buf;`
`410`		`-`
`411`		`- buf = bt_buf_get_evt(evt, false, K_NO_WAIT);`
`412`		`- if (buf) {`
`413`		`- net_buf_add_u8(h5.rx_buf, evt);`
`414`		`- }`
`415`		`-`
`416`		`- return buf;`
	`409`	`+ return bt_buf_get_evt(evt, false, K_NO_WAIT);`
`417`	`410`	`}`
`418`	`411`
`419`	`412`	`static void bt_uart_isr(struct device *unused)`