mgmt: ec_host_cmd: usb: fix double free

niedzwiecki-dawid · jhedberg · commit 58a7119d28ca · 2025-10-07T17:43:59.000+03:00
Fix double free of a net buffer after request error.

Signed-off-by: Dawid Niedzwiecki &lt;dawidn@google.com&gt;
diff --git a/subsys/mgmt/ec_host_cmd/backends/ec_host_cmd_backend_usb.c b/subsys/mgmt/ec_host_cmd/backends/ec_host_cmd_backend_usb.c
@@ -284,7 +284,6 @@ static int ec_host_cmd_request(struct usbd_class_data *const c_data, struct net_
 		if ((bi->ep == ec_host_cmd_get_in_int_ep(c_data)) ||
 		    (bi->ep == ec_host_cmd_get_out_ep(c_data))) {
 			usbd_ep_buf_free(uds_ctx, buf);
-			usbd_ep_buf_free(uds_ctx, buf);
 		}
 
 		return 0;

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,6 @@ static int ec_host_cmd_request(struct usbd_class_data *const c_data, struct net_`
`284`	`284`	`if ((bi->ep == ec_host_cmd_get_in_int_ep(c_data)) \|\|`
`285`	`285`	`(bi->ep == ec_host_cmd_get_out_ep(c_data))) {`
`286`	`286`	`usbd_ep_buf_free(uds_ctx, buf);`
`287`		`- usbd_ep_buf_free(uds_ctx, buf);`
`288`	`287`	`}`
`289`	`288`
`290`	`289`	`return 0;`