lib: getopt: Fix compiler warning.

koffes · cfriedt · commit 5974617db84b · 2023-05-09T11:03:44.000-04:00
current_dash may be used uninitialized

Signed-off-by: Kristoffer Rist Skøien &lt;kristoffer.skoien@nordicsemi.no&gt;
diff --git a/lib/posix/getopt/getopt_long.c b/lib/posix/getopt/getopt_long.c
@@ -172,7 +172,7 @@ parse_long_options(struct getopt_state *state, char * const *nargv,
 {
 	char *current_argv, *has_equal;
 #ifdef GNU_COMPATIBLE
-	char *current_dash;
+	char *current_dash = "";
 #endif
 	size_t current_argv_len;
 	int i, match, exact_match, second_partial_match;
@@ -191,7 +191,6 @@ parse_long_options(struct getopt_state *state, char * const *nargv,
 			current_dash = "-W ";
 			break;
 		default:
-			current_dash = "";
 			break;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ parse_long_options(struct getopt_state state, char const *nargv,`
`172`	`172`	`{`
`173`	`173`	`char current_argv, has_equal;`
`174`	`174`	`#ifdef GNU_COMPATIBLE`
`175`		`- char *current_dash;`
	`175`	`+ char *current_dash = "";`
`176`	`176`	`#endif`
`177`	`177`	`size_t current_argv_len;`
`178`	`178`	`int i, match, exact_match, second_partial_match;`
`@@ -191,7 +191,6 @@ parse_long_options(struct getopt_state state, char const *nargv,`
`191`	`191`	`current_dash = "-W ";`
`192`	`192`	`break;`
`193`	`193`	`default:`
`194`		`- current_dash = "";`
`195`	`194`	`break;`
`196`	`195`	`}`
`197`	`196`	`}`