drivers: ethernet: stm32: test HAL return value

Add missing test of some HAL functions return value

Signed-off-by: Etienne Carriere <[email protected]>

Author: etienne-lms

drivers/ethernet/eth_stm32_hal_v1.c

@@ -216,10 +216,14 @@ int eth_stm32_hal_init(const struct device *dev)
 	k_mutex_init(&dev_data->tx_mutex);
 	k_sem_init(&dev_data->rx_int_sem, 0, K_SEM_MAX_LIMIT);
 
-	HAL_ETH_DMATxDescListInit(heth, dma_tx_desc_tab,
-		&dma_tx_buffer[0][0], ETH_TXBUFNB);
-	HAL_ETH_DMARxDescListInit(heth, dma_rx_desc_tab,
-		&dma_rx_buffer[0][0], ETH_RXBUFNB);
+	if (HAL_ETH_DMATxDescListInit(heth, dma_tx_desc_tab,
+				      &dma_tx_buffer[0][0], ETH_TXBUFNB) != HAL_OK) {
+		return -EIO;
+	}
+	if (HAL_ETH_DMARxDescListInit(heth, dma_rx_desc_tab,
+				      &dma_rx_buffer[0][0], ETH_RXBUFNB) != HAL_OK) {
+		return -EIO;
+	}
 
 	return 0;
 }

drivers/ethernet/eth_stm32_hal_v2.c

@@ -134,18 +134,22 @@ static inline struct eth_stm32_tx_context *allocate_tx_context(struct net_pkt *p
 
 void eth_stm32_setup_mac_filter(ETH_HandleTypeDef *heth)
 {
-	__ASSERT_NO_MSG(heth != NULL);
 	ETH_MACFilterConfigTypeDef MACFilterConf;
+	HAL_StatusTypeDef hal_ret;
+
+	__ASSERT_NO_MSG(heth != NULL);
 
-	HAL_ETH_GetMACFilterConfig(heth, &MACFilterConf);
+	hal_ret = HAL_ETH_GetMACFilterConfig(heth, &MACFilterConf);
+	__ASSERT_NO_MSG(hal_ret == HAL_OK);
 
 	MACFilterConf.HashMulticast =
 		IS_ENABLED(CONFIG_ETH_STM32_MULTICAST_FILTER) ? ENABLE : DISABLE;
 	MACFilterConf.PassAllMulticast =
 		IS_ENABLED(CONFIG_ETH_STM32_MULTICAST_FILTER) ? DISABLE : ENABLE;
 	MACFilterConf.HachOrPerfectFilter = DISABLE;
 
-	HAL_ETH_SetMACFilterConfig(heth, &MACFilterConf);
+	hal_ret = HAL_ETH_SetMACFilterConfig(heth, &MACFilterConf);
+	__ASSERT_NO_MSG(hal_ret == HAL_OK);
 
 	k_sleep(K_MSEC(1));
 }
@@ -183,7 +187,9 @@ int eth_stm32_tx(const struct device *dev, struct net_pkt *pkt)
 			    net_pkt_is_tx_timestamping(pkt);
 	if (timestamped_frame) {
 		/* Enable transmit timestamp */
-		HAL_ETH_PTP_InsertTxTimestamp(heth);
+		if (HAL_ETH_PTP_InsertTxTimestamp(heth) != HAL_OK) {
+			return -EIO;
+		}
 	}
 #endif /* CONFIG_PTP_CLOCK_STM32_HAL */
 
@@ -276,7 +282,9 @@ int eth_stm32_tx(const struct device *dev, struct net_pkt *pkt)
 
 	if (!ctx) {
 		/* The HAL owns the tx context */
-		HAL_ETH_ReleaseTxPacket(heth);
+		if (HAL_ETH_ReleaseTxPacket(heth) != HAL_OK) {
+			return -EIO;
+		}
 	} else {
 		/* We need to release the tx context and its buffers */
 		HAL_ETH_TxFreeCallback((uint32_t *)ctx);
@@ -529,7 +537,11 @@ void eth_stm32_set_mac_config(const struct device *dev, struct phy_link_state *s
 	HAL_StatusTypeDef hal_ret = HAL_OK;
 	ETH_MACConfigTypeDef mac_config = {0};
 
-	HAL_ETH_GetMACConfig(heth, &mac_config);
+	if (HAL_ETH_GetMACConfig(heth, &mac_config) != HAL_OK) {
+		LOG_ERR("HAL_ETH_GetMACConfig: failed: %d", hal_ret);
+		ASSERT_NO_MSG(0);
+		return;
+	}
 
 	mac_config.DuplexMode =
 		PHY_LINK_IS_FULL_DUPLEX(state->speed) ? ETH_FULLDUPLEX_MODE : ETH_HALFDUPLEX_MODE;
@@ -604,11 +616,15 @@ int eth_stm32_hal_set_config(const struct device *dev,
 	case ETHERNET_CONFIG_TYPE_PROMISC_MODE:
 		ETH_MACFilterConfigTypeDef MACFilterConf;
 
-		HAL_ETH_GetMACFilterConfig(heth, &MACFilterConf);
+		if (HAL_ETH_GetMACFilterConfig(heth, &MACFilterConf) != HAL_OK) {
+			return -EIO;
+		}
 
 		MACFilterConf.PromiscuousMode = config->promisc_mode ? ENABLE : DISABLE;
 
-		HAL_ETH_SetMACFilterConfig(heth, &MACFilterConf);
+		if (HAL_ETH_SetMACFilterConfig(heth, &MACFilterConf) != HAL_OK) {
+			return -EIO;
+		}
 		return 0;
 #endif /* CONFIG_NET_PROMISCUOUS_MODE */
 #if defined(CONFIG_ETH_STM32_MULTICAST_FILTER)