samples: Bluetooth: Broadcast multiple legacy and extended advertising

cvinayak · cvinayak · commit 5b63d5d27000 · 2025-10-11T16:33:09.000+02:00
Update broadcaster_multiple sample to start multiple
advertising sets of type legacy and extended advertising.

Signed-off-by: Vinayak Kariappa Chettimada &lt;vich@nordicsemi.no&gt;
diff --git a/samples/bluetooth/broadcaster_multiple/overlay-bt_ll_sw_split.conf b/samples/bluetooth/broadcaster_multiple/overlay-bt_ll_sw_split.conf
@@ -0,0 +1,30 @@
+# Increased to 4 gives one each of legacy, 2M, 1M and Coded PHY advertising sets
+CONFIG_BT_EXT_ADV_MAX_ADV_SET=4
+
+# Use Zephyr Bluetooth Low Energy Controller
+CONFIG_BT_LL_SW_SPLIT=y
+
+# Enable Coded PHY support in Zephyr Controller, if testing 4 advertising sets
+CONFIG_BT_CTLR_PHY_CODED=y
+
+# Zephyr Bluetooth LE Controller will need to use chain PDUs when AD data
+# length > 191 bytes
+# - 31 bytes will use 22 bytes for the default name in this sample plus 9 bytes
+#   for manufacturer data
+# - 191 bytes will use 22 bytes for the default name in this sample plus 169
+#   bytes for manufacturer data
+# - 277 bytes will use 22 bytes for the default name in this sample plus 255
+#   bytes for manufacturer data
+CONFIG_BT_CTLR_ADV_DATA_LEN_MAX=192
+
+# Increase Advertising PDU buffers to number of advertising sets times the
+# number of chain PDUs per advertising set when using Zephyr Bluetooth LE
+# Controller
+CONFIG_BT_CTLR_ADVANCED_FEATURES=y
+CONFIG_BT_CTLR_ADV_RESERVE_MAX=n
+CONFIG_BT_CTLR_ADV_DATA_BUF_MAX=6
+CONFIG_BT_CTLR_ADV_DATA_CHAIN=y
+
+# Code size reduction
+CONFIG_ISR_TABLES_LOCAL_DECLARATION=y
+CONFIG_LTO=y
diff --git a/samples/bluetooth/broadcaster_multiple/prj.conf b/samples/bluetooth/broadcaster_multiple/prj.conf
@@ -1,23 +1,11 @@
 CONFIG_BT=y
 CONFIG_BT_BROADCASTER=y
-CONFIG_BT_EXT_ADV=y
-CONFIG_BT_EXT_ADV_MAX_ADV_SET=2
 CONFIG_BT_DEVICE_NAME="Broadcaster Multiple"
-
 CONFIG_LOG=y
 
-# Zephyr Bluetooth LE Controller will need to use chain PDUs when AD data
-# length > 191 bytes
-# - 31 bytes will use 22 bytes for the default name in this sample plus 9 bytes
-#   for manufacturer data
-# - 191 bytes will use 22 bytes for the default name in this sample plus 169
-#   bytes for manufacturer data
-# - 277 bytes will use 22 bytes for the default name in this sample plus 255
-#   bytes for manufacturer data
-# CONFIG_BT_CTLR_ADV_DATA_LEN_MAX=192
+# Require Bluetooth Advertising Extensions Feature
+CONFIG_BT_EXT_ADV=y
 
-# Increase Advertising PDU buffers to number of advertising sets times the
-# number of chain PDUs per advertising set when using Zephyr Bluetooth LE
-# Controller
-# CONFIG_BT_CTLR_ADVANCED_FEATURES=y
-# CONFIG_BT_CTLR_ADV_DATA_BUF_MAX=2
+# Increase to 4; gives one each of legacy, 2M, 1M and Coded PHY advertising sets, if supported by
+# Controller implementation
+CONFIG_BT_EXT_ADV_MAX_ADV_SET=2
diff --git a/samples/bluetooth/broadcaster_multiple/sample.yaml b/samples/bluetooth/broadcaster_multiple/sample.yaml
@@ -1,14 +1,24 @@
 sample:
   name: Bluetooth Multiple Extended Advertising Broadcaster
 tests:
-  sample.bluetooth.multiple_broadcast:
+  sample.bluetooth.broadcaster_multiple:
     harness: bluetooth
+    tags: bluetooth
     platform_allow:
       - qemu_cortex_m3
       - qemu_x86
+    integration_platforms:
+      - qemu_cortex_m3
+  sample.bluetooth.broadcaster_multiple.bt_ll_sw_split:
+    harness: bluetooth
+    tags: bluetooth
+    extra_args:
+      - EXTRA_CONF_FILE=overlay-bt_ll_sw_split.conf
+    platform_allow:
       - nrf51dk/nrf51822
       - nrf52_bsim
       - nrf52dk/nrf52832
-    tags: bluetooth
+      - nrf52840dk/nrf52840
     integration_platforms:
-      - qemu_cortex_m3
+      - nrf52dk/nrf52832
+      - nrf52840dk/nrf52840
diff --git a/samples/bluetooth/broadcaster_multiple/src/broadcaster_multiple.c b/samples/bluetooth/broadcaster_multiple/src/broadcaster_multiple.c
@@ -54,44 +54,95 @@
  */
 static uint8_t mfg_data[BT_MFG_DATA_LEN] = { 0xFF, 0xFF, };
 
-static const struct bt_data ad[] = {
+static const struct bt_data ad_long[] = {
 	BT_DATA(BT_DATA_MANUFACTURER_DATA, mfg_data, sizeof(mfg_data)),
 #if CONFIG_BT_CTLR_ADV_DATA_LEN_MAX > 255
 	BT_DATA(BT_DATA_MANUFACTURER_DATA, mfg_data, sizeof(mfg_data)),
 #endif
 	BT_DATA(BT_DATA_NAME_COMPLETE, CONFIG_BT_DEVICE_NAME, sizeof(CONFIG_BT_DEVICE_NAME) - 1),
 };
 
+static const struct bt_data ad_short[] = {
+	BT_DATA(BT_DATA_NAME_COMPLETE, CONFIG_BT_DEVICE_NAME, sizeof(CONFIG_BT_DEVICE_NAME) - 1),
+};
+
 static struct bt_le_ext_adv *adv[CONFIG_BT_EXT_ADV_MAX_ADV_SET];
 
 int broadcaster_multiple(void)
 {
-	struct bt_le_adv_param adv_param = {
-		.id = BT_ID_DEFAULT,
-		.sid = 0U, /* Supply unique SID when creating advertising set */
-		.secondary_max_skip = 0U,
-		.options = BT_LE_ADV_OPT_EXT_ADV,
-		.interval_min = BT_GAP_ADV_FAST_INT_MIN_2,
-		.interval_max = BT_GAP_ADV_FAST_INT_MAX_2,
-		.peer = NULL,
-	};
 	int err;
 
+	/* Create and start Advertising Sets */
 	for (int index = 0; index < CONFIG_BT_EXT_ADV_MAX_ADV_SET; index++) {
+		struct bt_le_adv_param adv_param = {
+			.id = BT_ID_DEFAULT,
+			.sid = 0U, /* Supply unique SID when creating advertising set */
+			.secondary_max_skip = 0U,
+			.options = BT_LE_ADV_OPT_EXT_ADV,
+			.interval_min = BT_GAP_ADV_FAST_INT_MIN_2,
+			.interval_max = BT_GAP_ADV_FAST_INT_MAX_2,
+			.peer = NULL,
+		};
+		const struct adv_param_config {
+			uint32_t options;
+			const struct bt_data *ad;
+			size_t ad_size;
+		} param_config[] = {
+		{ /* Use 1M legacy PDU */
+			.options = BT_LE_ADV_OPT_NONE,
+			.ad = ad_short,
+			.ad_size = ARRAY_SIZE(ad_short),
+		},
+		{ /* Use 2M auxiliary PDU */
+			.options = BT_LE_ADV_OPT_EXT_ADV,
+			.ad = ad_long,
+			.ad_size = ARRAY_SIZE(ad_long),
+		},
+		{ /* Use 1M auxiliary PDU */
+			.options = BT_LE_ADV_OPT_EXT_ADV | BT_LE_ADV_OPT_NO_2M,
+			.ad = ad_long,
+			.ad_size = ARRAY_SIZE(ad_long),
+		},
+		{ /* Use Coded PHY */
+			.options = BT_LE_ADV_OPT_EXT_ADV | BT_LE_ADV_OPT_CODED,
+			.ad = ad_long,
+			.ad_size = ARRAY_SIZE(ad_long),
+		}};
+		const struct bt_data *ad;
+		size_t ad_size;
+
 		/* Use advertising set instance index as SID */
 		adv_param.sid = index;
 
+		/* Advertising set options, AD and AD array size */
+		const struct adv_param_config *config =
+			&param_config[index % ARRAY_SIZE(param_config)];
+
+		adv_param.options = config->options;
+		ad = config->ad;
+		ad_size = config->ad_size;
+
+ext_adv_create_retry:
 		/* Create a non-connectable advertising set */
 		err = bt_le_ext_adv_create(&adv_param, NULL, &adv[index]);
 		if (err) {
-			printk("Failed to create advertising set %d (err %d)\n",
-			       index, err);
+			/* Failed creating Coded PHY advertising set? */
+			if ((adv_param.options & BT_LE_ADV_OPT_CODED) != 0U) {
+				printk("Failed to create advertising set %d with Coded PHY "
+				       "(err %d), retry without...\n", index, err);
+
+				/* Retry with non-Coded PHY advertising set */
+				adv_param.options &= ~BT_LE_ADV_OPT_CODED;
+
+				goto ext_adv_create_retry;
+			}
+
+			printk("Failed to create advertising set %d (err %d)\n", index, err);
 			return err;
 		}
 
 		/* Set extended advertising data */
-		err = bt_le_ext_adv_set_data(adv[index], ad, ARRAY_SIZE(ad),
-					     NULL, 0);
+		err = bt_le_ext_adv_set_data(adv[index], ad, ad_size, NULL, 0);
 		if (err) {
 			printk("Failed to set advertising data for set %d "
 			       "(err %d)\n", index, err);
diff --git a/samples/bluetooth/observer/src/observer.c b/samples/bluetooth/observer/src/observer.c
@@ -9,8 +9,6 @@
 #include <zephyr/bluetooth/bluetooth.h>
 #include <zephyr/bluetooth/hci.h>
 
-#define NAME_LEN 30
-
 static void device_found(const bt_addr_le_t *addr, int8_t rssi, uint8_t type,
 			 struct net_buf_simple *ad)
 {
@@ -22,6 +20,8 @@ static void device_found(const bt_addr_le_t *addr, int8_t rssi, uint8_t type,
 }
 
 #if defined(CONFIG_BT_EXT_ADV)
+#define NAME_LEN 30
+
 static bool data_cb(struct bt_data *data, void *user_data)
 {
 	char *name = user_data;
@@ -86,7 +86,7 @@ static struct bt_le_scan_cb scan_callbacks = {
 };
 #endif /* CONFIG_BT_EXT_ADV */
 
-int observer_start(void)
+static int scan_start(void)
 {
 	/* 30 ms continuous active scanning with duplicate filtering. */
 	struct bt_le_scan_param scan_param = {
@@ -98,16 +98,45 @@ int observer_start(void)
 	int err;
 
 #if defined(CONFIG_BT_EXT_ADV)
-	bt_le_scan_cb_register(&scan_callbacks);
-	printk("Registered scan callbacks\n");
+	scan_param.options |= BT_LE_SCAN_OPT_CODED;
 #endif /* CONFIG_BT_EXT_ADV */
 
+scan_start_retry:
+	printk("Starting scanning...\n");
 	err = bt_le_scan_start(&scan_param, device_found);
 	if (err) {
+		if ((scan_param.options & BT_LE_SCAN_OPT_CODED) != 0U) {
+			printk("Failed to start scanning with Coded PHY (err %d), retrying "
+			       "without...\n", err);
+
+			scan_param.options &= ~BT_LE_SCAN_OPT_CODED;
+
+			goto scan_start_retry;
+		}
+
 		printk("Start scanning failed (err %d)\n", err);
+
+		return err;
+	}
+
+	printk("success.\n");
+
+	return 0;
+}
+
+int observer_start(void)
+{
+	int err;
+
+#if defined(CONFIG_BT_EXT_ADV)
+	bt_le_scan_cb_register(&scan_callbacks);
+	printk("Registered scan callbacks\n");
+#endif /* CONFIG_BT_EXT_ADV */
+
+	err = scan_start();
+	if (err != 0) {
 		return err;
 	}
-	printk("Started scanning...\n");
 
 	return 0;
 }
diff --git a/subsys/bluetooth/controller/ll_sw/ull_adv_aux.c b/subsys/bluetooth/controller/ll_sw/ull_adv_aux.c
@@ -3178,6 +3178,14 @@ void ull_adv_aux_lll_auxptr_fill(struct pdu_adv *pdu, struct lll_adv *adv)
 }
 
 #else /* !CONFIG_BT_TICKER_EXT_EXPIRE_INFO */
+
+/* Maximum retries when ticks_current can change, example, when 3 extended advertising sets
+ * configured, and 1 advertising set is calculating the aux_offset, 2 other advertising sets and 2
+ * scanning instances can expire changing the ticks_current value while we are querying for
+ * aux_offset value.
+ */
+#define MAX_RETRY_TICKS_CURRENT_CHANGE ((CONFIG_BT_CTLR_ADV_AUX_SET) - 1U +  2U)
+
 static void mfy_aux_offset_get(void *param)
 {
 	struct pdu_adv_aux_ptr *aux_ptr;
@@ -3205,7 +3213,7 @@ static void mfy_aux_offset_get(void *param)
 	id = TICKER_NULL;
 	ticks_to_expire = 0U;
 	ticks_current = adv->ticks_at_expire;
-	retry = 4U; /* Assert on 2 other adv set ticks_current change, and 2 scanners expiring */
+	retry = MAX_RETRY_TICKS_CURRENT_CHANGE;
 	do {
 		uint32_t volatile ret_cb;
 		uint32_t ticks_previous;
diff --git a/tests/bsim/bluetooth/host/adv/chain/prj.conf b/tests/bsim/bluetooth/host/adv/chain/prj.conf
@@ -1,12 +1,14 @@
 CONFIG_BT=y
+
+# Broadcaster
 CONFIG_BT_BROADCASTER=y
-CONFIG_BT_OBSERVER=y
 CONFIG_BT_EXT_ADV=y
-CONFIG_BT_EXT_ADV_MAX_ADV_SET=2
+CONFIG_BT_EXT_ADV_MAX_ADV_SET=4
 CONFIG_BT_DEVICE_NAME="Broadcaster Multiple"
 
 # Enable Advertising Data chaining in Zephyr Bluetooth LE Controller
 CONFIG_BT_CTLR_ADVANCED_FEATURES=y
+CONFIG_BT_CTLR_ADV_RESERVE_MAX=n
 CONFIG_BT_CTLR_ADV_DATA_CHAIN=y
 
 # Zephyr Bluetooth LE Controller will need to use chain PDUs when AD data
@@ -22,19 +24,36 @@ CONFIG_BT_CTLR_ADV_DATA_LEN_MAX=1650
 # Increase Advertising PDU buffers to number of advertising sets times the
 # number of chain PDUs per advertising set when using Zephyr Bluetooth LE
 # Controller
-CONFIG_BT_CTLR_ADV_DATA_BUF_MAX=2
+CONFIG_BT_CTLR_ADV_DATA_BUF_MAX=6
+
+# Enable Coded PHY
+CONFIG_BT_CTLR_PHY_CODED=y
+
+# Observer
+CONFIG_BT_OBSERVER=y
+CONFIG_BT_EXT_ADV=y
 
 # Maximum Extended Scanning buffer size
 CONFIG_BT_EXT_SCAN_BUF_SIZE=1650
 
-# Set maximum scan data length for Extended Scanning in Bluetooth LE Controller
-CONFIG_BT_CTLR_SCAN_DATA_LEN_MAX=1650
-
 # The Zephyr Controller does not combine all the 1650 bytes before
 # fragmenting into 8 HCI reports, if a PDU has 255 bytes,
 # it will generate 2 HCI reports and so we need to reserve 16 buffers
 CONFIG_BT_BUF_EVT_RX_COUNT=16
 
+# Set maximum scan data length for Extended Scanning in Bluetooth LE Controller
+CONFIG_BT_CTLR_SCAN_DATA_LEN_MAX=1650
+
 # Increase Zephyr Bluetooth LE Controller Rx buffer to receive complete chain
 # of PDUs
 CONFIG_BT_CTLR_RX_BUFFERS=9
+
+# Enable scanning interleaved extended advertising in Zephyr Bluetooth LE
+# Controller
+CONFIG_BT_CTLR_ADVANCED_FEATURES=y
+CONFIG_BT_CTLR_SCAN_AUX_SET=3
+CONFIG_BT_CTLR_LOW_LAT_ULL=y
+# CONFIG_BT_CTLR_SCAN_AUX_USE_CHAINS=y
+# CONFIG_BT_CTLR_SCAN_AUX_CHAIN_COUNT=3
+CONFIG_BT_CTLR_SCAN_UNRESERVED=y
+# CONFIG_BT_TICKER_EXT_EXPIRE_INFO=y
diff --git a/tests/bsim/bluetooth/host/adv/chain/src/main.c b/tests/bsim/bluetooth/host/adv/chain/src/main.c
diff --git a/tests/bsim/bluetooth/host/adv/chain/tests_scripts/adv_chain.sh b/tests/bsim/bluetooth/host/adv/chain/tests_scripts/adv_chain.sh
