dma: dw: Align error code for xrun reporting

softwarecki · fabiobaltieri · commit 5d902ea621e4 · 2023-01-19T15:45:16.000Z
The hda driver uses -EPIPE to signal xrun, as proposed in the alsa lib https://www.alsa-project.org/alsa-doc/alsa-lib/pcm.html. This commit changes the xrun error code in dw dma driver from -ENODATA to -EPIPE to make it consistent across drivers. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
diff --git a/drivers/dma/dma_dw_common.c b/drivers/dma/dma_dw_common.c
@@ -786,7 +786,7 @@ int dw_dma_get_status(const struct device *dev, uint32_t channel,
 #if CONFIG_DMA_DW_HW_LLI
 	if (!(dw_read(dev_cfg->base, DW_DMA_CHAN_EN) & DW_CHAN(channel))) {
 		LOG_ERR("xrun detected");
-		return -ENODATA;
+		return -EPIPE;
 	}
 #endif
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -786,7 +786,7 @@ int dw_dma_get_status(const struct device *dev, uint32_t channel,`
`786`	`786`	`#if CONFIG_DMA_DW_HW_LLI`
`787`	`787`	`if (!(dw_read(dev_cfg->base, DW_DMA_CHAN_EN) & DW_CHAN(channel))) {`
`788`	`788`	`LOG_ERR("xrun detected");`
`789`		`- return -ENODATA;`
	`789`	`+ return -EPIPE;`
`790`	`790`	`}`
`791`	`791`	`#endif`
`792`	`792`	`return 0;`