Skip to content

Commit 5e6c733

Browse files
Krishna Tcarlescufi
authored andcommitted
net: wifi: Use a macro for TWT wake interval
Remove the magic number 255, esp. now that we support 262.144ms. Signed-off-by: Krishna T <[email protected]>
1 parent 65aae9c commit 5e6c733

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

include/zephyr/net/wifi_mgmt.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,8 @@ struct wifi_twt_params {
230230
/* Flow ID is only 3 bits */
231231
#define WIFI_MAX_TWT_FLOWS 8
232232
#define WIFI_MAX_TWT_INTERVAL_US (ULONG_MAX - 1)
233+
/* 256 (u8) * 1TU */
234+
#define WIFI_MAX_TWT_WAKE_INTERVAL_US 262144
233235
struct wifi_twt_flow_info {
234236
/* Interval = Wake up time + Sleeping time */
235237
uint64_t twt_interval;

subsys/net/l2/wifi/wifi_shell.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,8 @@ static int cmd_wifi_twt_setup_quick(const struct shell *sh, size_t argc,
599599
params.setup.trigger = 1;
600600
params.setup.announce = 0;
601601

602-
if (!parse_number(sh, (long *)&params.setup.twt_wake_interval, argv[idx++], 1, 255) ||
602+
if (!parse_number(sh, (long *)&params.setup.twt_wake_interval, argv[idx++],
603+
1, WIFI_MAX_TWT_WAKE_INTERVAL_US) ||
603604
!parse_number(sh, (long *)&params.setup.twt_interval, argv[idx++], 1,
604605
WIFI_MAX_TWT_INTERVAL_US))
605606
return -EINVAL;
@@ -648,7 +649,8 @@ static int cmd_wifi_twt_setup(const struct shell *sh, size_t argc,
648649
!parse_number(sh, (long *)&params.setup.trigger, argv[idx++], 0, 1) ||
649650
!parse_number(sh, (long *)&params.setup.implicit, argv[idx++], 0, 1) ||
650651
!parse_number(sh, (long *)&params.setup.announce, argv[idx++], 0, 1) ||
651-
!parse_number(sh, (long *)&params.setup.twt_wake_interval, argv[idx++], 1, 255) ||
652+
!parse_number(sh, (long *)&params.setup.twt_wake_interval, argv[idx++], 1,
653+
WIFI_MAX_TWT_WAKE_INTERVAL_US) ||
652654
!parse_number(sh, (long *)&params.setup.twt_interval, argv[idx++], 1,
653655
WIFI_MAX_TWT_INTERVAL_US))
654656
return -EINVAL;

0 commit comments

Comments
 (0)