pm: Remove "power state consistency" check

This check is totally wrong, min-residency-us and exit-latency-us are
not related to each other at all except that the end of the residency
period occurs when the exit starts, so they are totally orthogonal
values and should not be checking if one is less than the other or
anything like this. Even in the code for the default policy manager,
they are added together, so this check is incompatible / in disagreement
with that code, so it should be removed.

Signed-off-by: Declan Snyder <[email protected]>

Author: decsny

subsys/pm/state.c

@@ -11,34 +11,6 @@
 BUILD_ASSERT(DT_NODE_EXISTS(DT_PATH(cpus)),
 	     "cpus node not defined in Devicetree");
 
-/**
- * Check CPU power state consistency.
- *
- * @param i Power state index.
- * @param node_id CPU node identifier.
- */
-#define CHECK_POWER_STATE_CONSISTENCY(i, node_id)			       \
-	BUILD_ASSERT(							       \
-		DT_PROP_BY_PHANDLE_IDX_OR(node_id, cpu_power_states, i,	       \
-					  min_residency_us, 0U) >=	       \
-		DT_PROP_BY_PHANDLE_IDX_OR(node_id, cpu_power_states, i,	       \
-					  exit_latency_us, 0U),		       \
-		"Found CPU power state with min_residency < exit_latency")
-
-/**
- * @brief Check CPU power states consistency
- *
- * All states should have a minimum residency >= than the exit latency.
- *
- * @param node_id A CPU node identifier.
- */
-#define CHECK_POWER_STATES_CONSISTENCY(node_id)				       \
-	LISTIFY(DT_PROP_LEN_OR(node_id, cpu_power_states, 0),		       \
-		CHECK_POWER_STATE_CONSISTENCY, (;), node_id);		       \
-
-/* Check that all power states are consistent */
-DT_FOREACH_CHILD(DT_PATH(cpus), CHECK_POWER_STATES_CONSISTENCY)
-
 #define DEFINE_CPU_STATES(n) \
 	static const struct pm_state_info pmstates_##n[] \
 		= PM_STATE_INFO_LIST_FROM_DT_CPU(n);