Skip to content

Commit 61aefee

Browse files
nashifmmahadevan108
authored andcommitted
twister: stats: skipped testcases are part of selected group
Count skipped cases as part of selected group in stats. Signed-off-by: Anas Nashif <[email protected]>
1 parent 1647b46 commit 61aefee

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

scripts/pylib/twister/twisterlib/runner.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ def _find_number_length(n):
144144
return length
145145

146146
def summary(self):
147-
executed_cases = self.cases - self.skipped_cases - self.filtered_cases
147+
selected_cases = self.cases - self.filtered_cases
148148
completed_configs = self.done - self.skipped_filter
149149

150150
# Find alignment length for aesthetic printing
@@ -153,7 +153,7 @@ def summary(self):
153153
completed_suites_n_length = self._find_number_length(completed_configs)
154154
skipped_suites_n_length = self._find_number_length(self.skipped_configs)
155155
total_cases_n_length = self._find_number_length(self.cases)
156-
executed_cases_n_length = self._find_number_length(executed_cases)
156+
selected_cases_n_length = self._find_number_length(selected_cases)
157157

158158
print("--------------------------------------------------")
159159
print(f"{'Total test suites: ':<23}{self.total:>{suites_n_length}}") # actually test instances
@@ -172,19 +172,19 @@ def summary(self):
172172
print("---------------------- ----------------------")
173173
print(f"{'Total test cases: ':<18}{self.cases}")
174174
print(f"├─ {'Filtered test cases: ':<21}{self.filtered_cases:>{total_cases_n_length}}")
175-
print(f"{'Skipped test cases: ':<21}{self.skipped_cases:>{total_cases_n_length}}")
176-
print(f"{'Selected test cases: ':<21}{executed_cases:>{total_cases_n_length}}")
177-
print(f" ├─ {'Passed test cases: ':<25}{self.passed_cases:>{executed_cases_n_length}}")
178-
print(f" ├─ {'Built only test cases: ':<25}{self.notrun_cases:>{executed_cases_n_length}}")
179-
print(f" ├─ {'Blocked test cases: ':<25}{self.blocked_cases:>{executed_cases_n_length}}")
180-
print(f" ├─ {'Failed test cases: ':<25}{self.failed_cases:>{executed_cases_n_length}}")
181-
print(f" {'├' if self.none_cases or self.started_cases else '└'}{'Errors in test cases: ':<25}{self.error_cases:>{executed_cases_n_length}}")
175+
print(f"{'Selected test cases: ':<21}{selected_cases:>{total_cases_n_length}}")
176+
print(f"{'Passed test cases: ':<25}{self.passed_cases:>{selected_cases_n_length}}")
177+
print(f" ├─ {'Skipped test cases: ':<25}{self.skipped_cases:>{total_cases_n_length}}")
178+
print(f" ├─ {'Built only test cases: ':<25}{self.notrun_cases:>{selected_cases_n_length}}")
179+
print(f" ├─ {'Blocked test cases: ':<25}{self.blocked_cases:>{selected_cases_n_length}}")
180+
print(f" ├─ {'Failed test cases: ':<25}{self.failed_cases:>{selected_cases_n_length}}")
181+
print(f" {'├' if self.none_cases or self.started_cases else '└'}{'Errors in test cases: ':<25}{self.error_cases:>{selected_cases_n_length}}")
182182
if self.none_cases or self.started_cases:
183183
print(f" ├──── The following test case statuses should not appear in a proper execution ───")
184184
if self.none_cases:
185-
print(f" {'├' if self.started_cases else '└'}{'Statusless test cases: ':<25}{self.none_cases:>{executed_cases_n_length}}")
185+
print(f" {'├' if self.started_cases else '└'}{'Statusless test cases: ':<25}{self.none_cases:>{selected_cases_n_length}}")
186186
if self.started_cases:
187-
print(f" └─ {'Test cases only started: ':<25}{self.started_cases:>{executed_cases_n_length}}")
187+
print(f" └─ {'Test cases only started: ':<25}{self.started_cases:>{selected_cases_n_length}}")
188188
print("--------------------------------------------------")
189189

190190
@property

scripts/tests/twister/test_runner.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,9 +223,9 @@ def test_executioncounter(capfd):
223223
'---------------------- ----------------------\n'
224224
'Total test cases: 25\n'
225225
'├─ Filtered test cases: 0\n'
226-
'├─ Skipped test cases: 6\n'
227-
'└─ Selected test cases: 19\n'
226+
'└─ Selected test cases: 25\n'
228227
' ├─ Passed test cases: 0\n'
228+
' ├─ Skipped test cases: 6\n'
229229
' ├─ Built only test cases: 0\n'
230230
' ├─ Blocked test cases: 0\n'
231231
' ├─ Failed test cases: 0\n'

0 commit comments

Comments
 (0)