Skip to content

Commit 6269185

Browse files
ndrs-pstcarlescufi
authored andcommitted
drivers: serial: ra8_sci_b: revise switch-case in callback_adapter
Unified switch-case usage in `uart_ra_sci_b_callback_adapter` to use `break` instead of `return`. Typically, a `break` is used in switch-case statements unless an early return is necessary, in which case `return` is appropriate. For this case, using a `break` statement is the more suitable choice. Signed-off-by: Pisit Sawangvonganan <[email protected]>
1 parent d3ca4fd commit 6269185

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

drivers/serial/uart_renesas_ra8_sci_b.c

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -803,24 +803,28 @@ static void uart_ra_sci_b_callback_adapter(struct st_uart_callback_arg *fsp_args
803803
case UART_EVENT_TX_COMPLETE: {
804804
data->tx_buffer_len = data->tx_buffer_cap;
805805
async_update_tx_buffer(dev);
806-
return;
806+
break;
807807
}
808808
case UART_EVENT_RX_COMPLETE: {
809809
data->rx_buffer_len =
810810
data->rx_buffer_cap - data->rx_buffer_offset - data->sci.rx_dest_bytes;
811811
async_rx_ready(dev);
812812
async_release_rx_buffer(dev);
813813
async_replace_rx_buffer(dev);
814-
return;
814+
break;
815815
}
816816
case UART_EVENT_ERR_PARITY:
817-
return async_rx_error(dev, UART_ERROR_PARITY);
817+
async_rx_error(dev, UART_ERROR_PARITY);
818+
break;
818819
case UART_EVENT_ERR_FRAMING:
819-
return async_rx_error(dev, UART_ERROR_FRAMING);
820+
async_rx_error(dev, UART_ERROR_FRAMING);
821+
break;
820822
case UART_EVENT_ERR_OVERFLOW:
821-
return async_rx_error(dev, UART_ERROR_OVERRUN);
823+
async_rx_error(dev, UART_ERROR_OVERRUN);
824+
break;
822825
case UART_EVENT_BREAK_DETECT:
823-
return async_rx_error(dev, UART_BREAK);
826+
async_rx_error(dev, UART_BREAK);
827+
break;
824828
case UART_EVENT_TX_DATA_EMPTY:
825829
case UART_EVENT_RX_CHAR:
826830
break;

0 commit comments

Comments
 (0)