twister: device-handler: use --dev-id for STM32CubeProgrammer runner

Now that the STM32CubeProgrammer runner supports the standard `--dev-id`
argument, replace usage of `--tool-opt` in the Twister device handler code.

Signed-off-by: Mathieu Choplain <[email protected]>

Author: mathieuchopstm

scripts/pylib/twister/twisterlib/handlers.py

@@ -638,7 +638,8 @@ def _create_command(self, runner, hardware):
                     # --probe=<serial number> select by probe serial number
                     command.append(f"--probe={board_id}")
                 elif runner == "stm32cubeprogrammer" and product != "BOOT-SERIAL":
-                    command.append(f"--tool-opt=sn={board_id}")
+                    command.append('--dev-id')
+                    command.append(board_id)
 
                 # Receive parameters from runner_params field.
                 if hardware.runner_params:

scripts/tests/twister/test_handlers.py

@@ -1141,7 +1141,7 @@ def mock_availability(handler, instance, no=num_of_failures):
         'product',
         None,
         ['west', 'flash', '--skip-rebuild', '-d', '$build_dir',
-         '--runner', 'stm32cubeprogrammer', '--tool-opt=sn=12345',
+         '--runner', 'stm32cubeprogrammer', '--dev-id', 12345,
          'param1', 'param2']
     ),
     (