net: wifi: Fix 11k command errors

nxf58150 · dkalowsk · commit 67980643d799 · 2024-11-07T18:42:15.000-08:00
Add condition check so that the 11k flag will be updated for set
operation only.
Fix print log error when getting 11k status.

Signed-off-by: Hui Bai &lt;hui.bai@nxp.com&gt;
diff --git a/subsys/net/l2/wifi/wifi_mgmt.c b/subsys/net/l2/wifi/wifi_mgmt.c
@@ -741,7 +741,9 @@ static int wifi_11k_cfg(uint32_t mgmt_request, struct net_if *iface,
 	}
 
 #ifdef CONFIG_WIFI_NM_WPA_SUPPLICANT_ROAMING
-	roaming_params.is_11k_enabled = params->enable_11k;
+	if (params->oper == WIFI_MGMT_SET) {
+		roaming_params.is_11k_enabled = params->enable_11k;
+	}
 #endif
 
 	return wifi_mgmt_api->cfg_11k(dev, params);
diff --git a/subsys/net/l2/wifi/wifi_shell.c b/subsys/net/l2/wifi/wifi_shell.c
@@ -1248,7 +1248,7 @@ static int cmd_wifi_11k(const struct shell *sh, size_t argc, char *argv[])
 	}
 
 	if (params.oper == WIFI_MGMT_GET) {
-		PR("11k is %s\n", params.enable_11k ? "disabled" : "enabled");
+		PR("11k is %s\n", params.enable_11k ? "enabled" : "disabled");
 	} else {
 		PR("%s %s requested\n", argv[0], argv[1]);
 	}

Original file line number	Diff line number	Diff line change
`@@ -741,7 +741,9 @@ static int wifi_11k_cfg(uint32_t mgmt_request, struct net_if *iface,`
`741`	`741`	`}`
`742`	`742`
`743`	`743`	`#ifdef CONFIG_WIFI_NM_WPA_SUPPLICANT_ROAMING`
`744`		`- roaming_params.is_11k_enabled = params->enable_11k;`
	`744`	`+ if (params->oper == WIFI_MGMT_SET) {`
	`745`	`+ roaming_params.is_11k_enabled = params->enable_11k;`
	`746`	`+ }`
`745`	`747`	`#endif`
`746`	`748`
`747`	`749`	`return wifi_mgmt_api->cfg_11k(dev, params);`
Original file line number	Diff line number	Diff line change
`@@ -1248,7 +1248,7 @@ static int cmd_wifi_11k(const struct shell sh, size_t argc, char argv[])`
`1248`	`1248`	`}`
`1249`	`1249`
`1250`	`1250`	`if (params.oper == WIFI_MGMT_GET) {`
`1251`		`- PR("11k is %s\n", params.enable_11k ? "disabled" : "enabled");`
	`1251`	`+ PR("11k is %s\n", params.enable_11k ? "enabled" : "disabled");`
`1252`	`1252`	`} else {`
`1253`	`1253`	`PR("%s %s requested\n", argv[0], argv[1]);`
`1254`	`1254`	`}`