usb: device_next: usbd_cdc_ncm: correct net_if_carrier use

net_if_carrier is to be used independently of the
administrative state (start and stop of the ethernet_api).

This seem to work, including plugging the usb out and in again.

Signed-off-by: Fin Maaß <[email protected]>

Author: maass-hamburg

subsys/usb/device_next/class/usbd_cdc_ncm.c

@@ -815,6 +815,8 @@ static void send_notification_work(struct k_work *work)
 	dev = usbd_class_get_private(data->c_data);
 
 	if (atomic_test_bit(&data->state, CDC_NCM_IFACE_UP)) {
+		net_if_carrier_on(data->iface);
+
 		ret = ncm_send_notification_sequence(dev);
 	} else {
 		data->if_state = IF_STATE_INIT;
@@ -840,6 +842,7 @@ static void usbd_cdc_ncm_update(struct usbd_class_data *const c_data,
 
 	if (data_iface == iface && alternate == 0) {
 		atomic_clear_bit(&data->state, CDC_NCM_DATA_IFACE_ENABLED);
+		net_if_carrier_off(data->iface);
 		data->tx_seq = 0;
 		data->rx_seq = 0;
 	}
@@ -868,6 +871,8 @@ static void usbd_cdc_ncm_disable(struct usbd_class_data *const c_data)
 	atomic_clear_bit(&data->state, CDC_NCM_DATA_IFACE_ENABLED);
 	atomic_clear_bit(&data->state, CDC_NCM_CLASS_SUSPENDED);
 
+	net_if_carrier_off(data->iface);
+
 	LOG_INF("Disabled %s", c_data->name);
 }
 
@@ -877,6 +882,8 @@ static void usbd_cdc_ncm_suspended(struct usbd_class_data *const c_data)
 	struct cdc_ncm_eth_data *data = dev->data;
 
 	atomic_set_bit(&data->state, CDC_NCM_CLASS_SUSPENDED);
+
+	net_if_carrier_off(data->iface);
 }
 
 static void usbd_cdc_ncm_resumed(struct usbd_class_data *const c_data)
@@ -1123,7 +1130,6 @@ static int cdc_ncm_iface_start(const struct device *dev)
 	LOG_DBG("Start interface %d", net_if_get_by_iface(data->iface));
 
 	atomic_set_bit(&data->state, CDC_NCM_IFACE_UP);
-	net_if_carrier_on(data->iface);
 
 	if (atomic_test_bit(&data->state, CDC_NCM_DATA_IFACE_ENABLED)) {
 		(void)k_work_reschedule(&data->notif_work, K_MSEC(1));