Skip to content

Commit 6c98d41

Browse files
committed
shell: Fix builds for platforms without uart
We get build issues due to the removal of the Kconfig symbol CONFIG_UART_SHELL_ON_DEV_NAME on platforms that didn't have a uart set as we'd get a default value for those platforms. Update the Kconfig logic to only enable SHELL_BACKEND_SERIAL if we have zephyr,shell-uart specified in the devicetree to address the issue. Signed-off-by: Kumar Gala <[email protected]>
1 parent 61ef41f commit 6c98d41

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

subsys/shell/Kconfig.backends

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,13 @@ menuconfig SHELL_BACKENDS
1111

1212
if SHELL_BACKENDS
1313

14+
# Workaround for not being able to have commas in macro arguments
15+
DT_CHOSEN_Z_SHELL_UART := zephyr,shell-uart
16+
1417
config SHELL_BACKEND_SERIAL
1518
bool "Enable serial backend"
16-
default y
19+
default "$(dt_chosen_enabled,$(DT_CHOSEN_Z_SHELL_UART))" if HAS_DTS
20+
default y if !HAS_DTS
1721
select SERIAL
1822
select RING_BUFFER
1923
help

0 commit comments

Comments
 (0)