tests: Bluetooth: df: Add test to verify correctness of relase of PDUs

Add unit tests that will ensure the CTE disable operation does not
cause breaking of LLL operations by too early release of chained PDUs.
The tests verify if numbers of PDUs in free PDUs fifo and free PDUs
memory pool are correct.

Signed-off-by: Piotr Pryga <[email protected]>

Author: ppryga-nordic

subsys/bluetooth/controller/ll_sw/nordic/lll/lll_adv.c

@@ -1542,3 +1542,15 @@ static inline bool isr_rx_ci_adva_check(uint8_t tx_addr, uint8_t *addr,
 	return (tx_addr == ci->rx_addr) &&
 		!memcmp(addr, ci->connect_ind.adv_addr, BDADDR_SIZE);
 }
+
+#if defined(CONFIG_ZTEST)
+uint32_t lll_adv_free_pdu_fifo_count_get(void)
+{
+	return MFIFO_AVAIL_COUNT_GET(pdu_free);
+}
+
+uint32_t lll_adv_pdu_mem_free_count_get(void)
+{
+	return mem_free_count_get(mem_pdu.free);
+}
+#endif /* CONFIG_ZTEST */

subsys/bluetooth/controller/ll_sw/nordic/lll/lll_adv_internal.h

@@ -78,3 +78,8 @@ bool lll_adv_connect_ind_check(struct lll_adv *lll, struct pdu_adv *ci,
 			       uint8_t tx_addr, uint8_t *addr,
 			       uint8_t rx_addr, uint8_t *tgt_addr,
 			       uint8_t devmatch_ok, uint8_t *rl_idx);
+
+#if defined(CONFIG_ZTEST)
+uint32_t lll_adv_free_pdu_fifo_count_get(void);
+uint32_t lll_adv_pdu_mem_free_count_get(void);
+#endif /* CONFIG_ZTEST */

tests/bluetooth/df/connectionless_cte_chains/src/common.c

@@ -108,6 +108,8 @@ void common_release_adv_set(struct ll_adv_set *adv_set)
 		if (sync) {
 			sync->is_started = 0U;
 		}
+
+		lll_adv_data_reset(&sync->lll.data);
 	}
 	adv_set->lll.sync = NULL;
 	if (adv_set->df_cfg->is_enabled) {
@@ -196,8 +198,14 @@ void common_release_per_adv_chain(struct ll_adv_set *adv_set)
 
 	lll_sync = adv_set->lll.sync;
 	pdu = lll_adv_sync_data_peek(lll_sync, NULL);
+	if (pdu != NULL) {
+		lll_adv_pdu_linked_release_all(pdu);
+	}
 
-	lll_adv_pdu_linked_release_all(pdu);
+	pdu = (void *)lll_sync->data.pdu[lll_sync->data.first];
+	if (pdu != NULL) {
+		lll_adv_pdu_linked_release_all(pdu);
+	}
 }
 
 /*
@@ -443,6 +451,17 @@ void common_validate_chain_with_cte(struct ll_adv_set *adv, uint8_t cte_count,
 	}
 }
 
+/*
+ * @brief Helper function to cleanup after test case end.
+ *
+ * @param adv               Pointer to advertising set
+ */
+void common_teardown(struct ll_adv_set *adv)
+{
+	common_release_per_adv_chain(adv);
+	common_release_adv_set(adv);
+	lll_adv_init();
+}
 /*
  * @brief Helper function to add payload data to extended advertising PDU.
  *

tests/bluetooth/df/connectionless_cte_chains/src/common.h

@@ -19,3 +19,4 @@ void common_prepare_df_cfg(struct ll_adv_set *adv, uint8_t cte_count);
 void common_validate_per_adv_chain(struct ll_adv_set *adv, uint8_t pdu_count);
 void common_validate_chain_with_cte(struct ll_adv_set *adv, uint8_t cte_count,
 				    uint8_t ad_data_pdu_count);
+void common_teardown(struct ll_adv_set *adv);

tests/bluetooth/df/connectionless_cte_chains/src/test_add_cte_to_chain.c

@@ -23,6 +23,7 @@
 #include "lll/lll_adv_types.h"
 #include "lll_adv.h"
 #include "lll/lll_adv_pdu.h"
+#include "lll/lll_adv_internal.h"
 #include "lll_adv_sync.h"
 #include "lll/lll_df_types.h"
 
@@ -62,9 +63,7 @@ void test_add_number_of_cte_to_sigle_pdu_chain(void)
 	/* Validate result */
 	common_validate_chain_with_cte(adv, TEST_CTE_COUNT, TEST_PER_ADV_SINGLE_PDU);
 
-	/* Teardown */
-	common_release_per_adv_chain(adv);
-	common_release_adv_set(adv);
+	common_teardown(adv);
 }
 
 void test_add_cte_for_each_pdu_in_chain(void)
@@ -90,9 +89,7 @@ void test_add_cte_for_each_pdu_in_chain(void)
 	/* Validate result */
 	common_validate_chain_with_cte(adv, TEST_CTE_COUNT, TEST_CTE_COUNT);
 
-	/* Teardown */
-	common_release_per_adv_chain(adv);
-	common_release_adv_set(adv);
+	common_teardown(adv);
 }
 
 void test_add_cte_for_not_all_pdu_in_chain(void)
@@ -118,9 +115,44 @@ void test_add_cte_for_not_all_pdu_in_chain(void)
 	/* Validate result */
 	common_validate_chain_with_cte(adv, TEST_CTE_COUNT, TEST_PER_ADV_CHAIN_LENGTH);
 
-	/* Teardown */
-	common_release_per_adv_chain(adv);
-	common_release_adv_set(adv);
+	common_teardown(adv);
+}
+
+void test_add_cte_to_not_all_pdus_in_chain_enqueued_to_lll(void)
+{
+	struct pdu_adv *pdu_prev, *pdu_new;
+	struct ll_adv_set *adv;
+	uint8_t handle;
+	uint8_t upd;
+	int err;
+
+	/* Setup for test */
+	adv = common_create_adv_set(TEST_ADV_SET_HANDLE);
+	/* Use the same number for PDUs in a chain as for CTE request */
+	common_prepare_df_cfg(adv, TEST_CTE_COUNT);
+	common_create_per_adv_chain(adv, TEST_PER_ADV_CHAIN_LENGTH);
+	common_validate_per_adv_chain(adv, TEST_PER_ADV_CHAIN_LENGTH);
+
+	/* Swap PDU double buffer and get new latest PDU data */
+	pdu_new = lll_adv_sync_data_latest_get(adv->lll.sync, NULL, &upd);
+	zassert_not_equal(pdu_new, NULL,
+			  "Unexpected value of new PDU pointer after PDU double buffer swap");
+
+	pdu_prev = lll_adv_sync_data_peek(adv->lll.sync, NULL);
+	zassert_equal(pdu_prev, pdu_new,
+		      "Unexpected value of previous PDU pointer after PDU double buffer swap");
+
+	handle = ull_adv_handle_get(adv);
+
+	err = ll_df_set_cl_cte_tx_enable(handle, true);
+	zassert_equal(err, 0,
+		      "Unexpected error while enabling CTE for periodic avertising chain, err: %d",
+		      err);
+
+	/* Validate result */
+	common_validate_chain_with_cte(adv, TEST_CTE_COUNT, TEST_PER_ADV_CHAIN_LENGTH);
+
+	common_teardown(adv);
 }
 
 void test_add_cte_for_single_pdu_chain(void)
@@ -146,9 +178,7 @@ void test_add_cte_for_single_pdu_chain(void)
 	/* Validate result */
 	common_validate_chain_with_cte(adv, TEST_CTE_SINGLE, TEST_PER_ADV_SINGLE_PDU);
 
-	/* Teardown */
-	common_release_per_adv_chain(adv);
-	common_release_adv_set(adv);
+	common_teardown(adv);
 }
 
 void run_add_cte_to_per_adv_chain_tests(void)
@@ -157,6 +187,7 @@ void run_add_cte_to_per_adv_chain_tests(void)
 			 ztest_unit_test(test_add_number_of_cte_to_sigle_pdu_chain),
 			 ztest_unit_test(test_add_cte_for_each_pdu_in_chain),
 			 ztest_unit_test(test_add_cte_for_not_all_pdu_in_chain),
+			 ztest_unit_test(test_add_cte_to_not_all_pdus_in_chain_enqueued_to_lll),
 			 ztest_unit_test(test_add_cte_for_single_pdu_chain));
 	ztest_run_test_suite(test_add_cte_to_per_adv_chain);
 }