net: context: Fix memory leak

rettichschnidi · carlescufi · commit 6de54e0d0362 · 2022-09-14T14:38:34.000+01:00
Allocated, but undersized packets must not just be logged, but also
unreferenced before returning an error.

Signed-off-by: Reto Schneider &lt;reto.schneider@husqvarnagroup.com&gt;
diff --git a/subsys/net/ip/net_context.c b/subsys/net/ip/net_context.c
@@ -1669,7 +1669,8 @@ static int context_sendto(struct net_context *context,
 		if (net_context_get_type(context) == SOCK_DGRAM) {
 			NET_ERR("Available payload buffer (%zu) is not enough for requested DGRAM (%zu)",
 				tmp_len, len);
-			return -ENOMEM;
+			ret = -ENOMEM;
+			goto fail;
 		}
 		len = tmp_len;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1669,7 +1669,8 @@ static int context_sendto(struct net_context *context,`
`1669`	`1669`	`if (net_context_get_type(context) == SOCK_DGRAM) {`
`1670`	`1670`	`NET_ERR("Available payload buffer (%zu) is not enough for requested DGRAM (%zu)",`
`1671`	`1671`	`tmp_len, len);`
`1672`		`- return -ENOMEM;`
	`1672`	`+ ret = -ENOMEM;`
	`1673`	`+ goto fail;`
`1673`	`1674`	`}`
`1674`	`1675`	`len = tmp_len;`
`1675`	`1676`	`}`