net: tcp2: Use safe version of slist macro in conn search

jukkar · nashif · commit 6dfb11c7815c · 2020-09-18T22:07:53.000-04:00
Use SYS_SLIST_FOR_EACH_CONTAINER_SAFE() macro when searching
the connection list so that we notice if new entries are added
or removed in the list.

Signed-off-by: Jukka Rissanen &lt;jukka.rissanen@linux.intel.com&gt;
diff --git a/subsys/net/ip/tcp2.c b/subsys/net/ip/tcp2.c
@@ -942,8 +942,9 @@ static struct tcp *tcp_conn_search(struct net_pkt *pkt)
 {
 	bool found = false;
 	struct tcp *conn;
+	struct tcp *tmp;
 
-	SYS_SLIST_FOR_EACH_CONTAINER(&tcp_conns, conn, next) {
+	SYS_SLIST_FOR_EACH_CONTAINER_SAFE(&tcp_conns, conn, tmp, next) {
 
 		found = tcp_conn_cmp(conn, pkt);
 		if (found) {

Original file line number	Diff line number	Diff line change
`@@ -942,8 +942,9 @@ static struct tcp tcp_conn_search(struct net_pkt pkt)`
`942`	`942`	`{`
`943`	`943`	`bool found = false;`
`944`	`944`	`struct tcp *conn;`
	`945`	`+ struct tcp *tmp;`
`945`	`946`
`946`		`- SYS_SLIST_FOR_EACH_CONTAINER(&tcp_conns, conn, next) {`
	`947`	`+ SYS_SLIST_FOR_EACH_CONTAINER_SAFE(&tcp_conns, conn, tmp, next) {`
`947`	`948`
`948`	`949`	`found = tcp_conn_cmp(conn, pkt);`
`949`	`950`	`if (found) {`