Skip to content

Commit 6ea6e57

Browse files
nordic-krchkartben
authored andcommitted
tests: arch: Fix zassert string
Fix wrong parameters used in zassert macros. Signed-off-by: Krzysztof Chruściński <[email protected]>
1 parent 95737cd commit 6ea6e57

File tree

4 files changed

+9
-13
lines changed

4 files changed

+9
-13
lines changed

tests/arch/arm/arm_irq_vector_table/src/arm_irq_vector_table.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,7 @@ ZTEST(vector_table, test_arm_irq_vector_table)
105105
}
106106

107107
zassert_true((k_sem_take(&sem[0], K_NO_WAIT) || k_sem_take(&sem[1], K_NO_WAIT) ||
108-
k_sem_take(&sem[2], K_NO_WAIT)),
109-
NULL);
108+
k_sem_take(&sem[2], K_NO_WAIT)));
110109

111110
for (int ii = 0; ii < 3; ii++) {
112111
#if defined(CONFIG_ARMV6_M_ARMV8_M_BASELINE) || defined(CONFIG_SOC_TI_LM3S6965_QEMU)
@@ -129,8 +128,7 @@ ZTEST(vector_table, test_arm_irq_vector_table)
129128
__ISB(); /* Ensure that IRQ is executed */
130129

131130
zassert_false((k_sem_take(&sem[0], K_NO_WAIT) || k_sem_take(&sem[1], K_NO_WAIT) ||
132-
k_sem_take(&sem[2], K_NO_WAIT)),
133-
NULL);
131+
k_sem_take(&sem[2], K_NO_WAIT)));
134132
}
135133

136134
typedef void (*vth)(void); /* Vector Table Handler */

tests/arch/arm/arm_thread_swap/src/arm_thread_arch.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,8 @@ static void verify_fp_callee_saved(const struct _preempt_float *src,
147147
(src->s27 == dst->s27) && (src->s28 == dst->s28) &&
148148
(src->s29 == dst->s29) && (src->s30 == dst->s30) &&
149149
(src->s31 == dst->s31),
150-
" got: 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x"
151-
" 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x\n"
152-
" expected: 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x"
153-
" 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x 0x%0x\n",
150+
" got: %f %f %f %f %f %f %f %f %f %f %f %f %f %f %f %f\n"
151+
" expected: %f %f %f %f %f %f %f %f %f %f %f %f %f %f %f %f\n",
154152
(double)src->s16, (double)src->s17, (double)src->s18, (double)src->s19,
155153
(double)src->s20, (double)src->s21, (double)src->s22, (double)src->s23,
156154
(double)src->s24, (double)src->s25, (double)src->s26, (double)src->s27,

tests/arch/arm/arm_tz_wrap_func/src/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ ZTEST(tz_wrap_func, test_tz_wrap_func)
8080
msp1 = __get_MSP();
8181
psp1 = __get_PSP();
8282

83-
zassert_equal(foo1_retval, wrap_foo1(foo1_arg1, foo1_arg2, foo1_arg3, foo1_arg4), NULL);
83+
zassert_equal(foo1_retval, wrap_foo1(foo1_arg1, foo1_arg2, foo1_arg3, foo1_arg4));
8484

8585
zassert_equal(msp1, __get_MSP());
8686
zassert_equal(psp1, __get_PSP());

tests/arch/common/semihost/src/main.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ ZTEST(semihost, test_file_ops)
1717

1818
/* Open in write mode */
1919
fd = semihost_open(test_file, SEMIHOST_OPEN_WB);
20-
zassert_true(fd > 0, "Bad handle (%d)", fd);
20+
zassert_true(fd > 0, "Bad handle (%ld)", fd);
2121
zassert_equal(semihost_flen(fd), 0, "File not empty");
2222

2323
/* Write some data */
@@ -35,12 +35,12 @@ ZTEST(semihost, test_file_ops)
3535

3636
/* Open the same file again for reading */
3737
fd = semihost_open(test_file, SEMIHOST_OPEN_RB);
38-
zassert_true(fd > 0, "Bad handle (%d)", fd);
38+
zassert_true(fd > 0, "Bad handle (%ld)", fd);
3939
zassert_equal(semihost_flen(fd), 2 * sizeof(w_buffer), "Data not preserved");
4040

4141
/* Check reading data */
4242
read = semihost_read(fd, r_buffer, sizeof(r_buffer));
43-
zassert_equal(read, sizeof(r_buffer), "Read failed %d", read);
43+
zassert_equal(read, sizeof(r_buffer), "Read failed %ld", read);
4444
zassert_mem_equal(r_buffer, w_buffer, sizeof(r_buffer), "Data not read");
4545
read = semihost_read(fd, r_buffer, sizeof(r_buffer));
4646
zassert_equal(read, sizeof(r_buffer), "Read failed");
@@ -63,7 +63,7 @@ ZTEST(semihost, test_file_ops)
6363

6464
/* Opening again in write mode should erase the file */
6565
fd = semihost_open(test_file, SEMIHOST_OPEN_WB);
66-
zassert_true(fd > 0, "Bad handle (%d)", fd);
66+
zassert_true(fd > 0, "Bad handle (%ld)", fd);
6767
zassert_equal(semihost_flen(fd), 0, "File not empty");
6868
zassert_equal(semihost_close(fd), 0, "Close failed");
6969
}

0 commit comments

Comments
 (0)