Skip to content

Commit 73fd29f

Browse files
nashifkartben
authored andcommitted
twister: logging: verbose names for logging handlers
Trivial rename of variables to make them more clear. Signed-off-by: Anas Nashif <[email protected]>
1 parent 96ab891 commit 73fd29f

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

scripts/pylib/twister/twisterlib/twister_main.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,15 @@
2828
def setup_logging(outdir, log_file, log_level, timestamps):
2929
# create file handler which logs even debug messages
3030
if log_file:
31-
fh = logging.FileHandler(log_file)
31+
file_handler = logging.FileHandler(log_file)
3232
else:
33-
fh = logging.FileHandler(os.path.join(outdir, "twister.log"))
33+
file_handler = logging.FileHandler(os.path.join(outdir, "twister.log"))
3434

35-
fh.setLevel(logging.DEBUG)
35+
file_handler.setLevel(logging.DEBUG)
3636

3737
# create console handler with a higher log level
38-
ch = logging.StreamHandler()
39-
ch.setLevel(getattr(logging, log_level))
38+
console_handler = logging.StreamHandler()
39+
console_handler.setLevel(getattr(logging, log_level))
4040

4141
# create formatter and add it to the handlers
4242
if timestamps:
@@ -47,12 +47,12 @@ def setup_logging(outdir, log_file, log_level, timestamps):
4747
formatter_file = logging.Formatter(
4848
"%(asctime)s - %(name)s - %(levelname)s - %(message)s"
4949
)
50-
ch.setFormatter(formatter)
51-
fh.setFormatter(formatter_file)
50+
console_handler.setFormatter(formatter)
51+
file_handler.setFormatter(formatter_file)
5252

5353
# add the handlers to logger
54-
logger.addHandler(ch)
55-
logger.addHandler(fh)
54+
logger.addHandler(console_handler)
55+
logger.addHandler(file_handler)
5656

5757

5858
def init_color(colorama_strip):

0 commit comments

Comments
 (0)