drivers: sensor: bosch: bme680: fix: possible overflowed value return value

fabocode · fabiobaltieri · commit 746ea32edc92 · 2025-03-05T09:58:35.000Z
- Check if value exceeds limits of the variable

Signed-off-by: Fabian Barraez &lt;fabianbarraez@gmail.com&gt;
diff --git a/drivers/sensor/bosch/bme680/bme680.c b/drivers/sensor/bosch/bme680/bme680.c
@@ -207,7 +207,9 @@ static uint8_t bme680_calc_gas_wait(uint16_t dur)
 			dur = dur / 4;
 			factor += 1;
 		}
-		durval = dur + (factor * 64);
+		const uint16_t max_duration = dur + (factor * 64);
+
+		durval = CLAMP(max_duration, 0, 0xff);
 	}
 
 	return durval;

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,9 @@ static uint8_t bme680_calc_gas_wait(uint16_t dur)`
`207`	`207`	`dur = dur / 4;`
`208`	`208`	`factor += 1;`
`209`	`209`	`}`
`210`		`- durval = dur + (factor * 64);`
	`210`	`+ const uint16_t max_duration = dur + (factor * 64);`
	`211`	`+`
	`212`	`+ durval = CLAMP(max_duration, 0, 0xff);`
`211`	`213`	`}`
`212`	`214`
`213`	`215`	`return durval;`