drivers: serial: cmsdk_apb: fix irq_rx_ready deviation

radsemijmitchell · cfriedt · commit 74d08d69b2c1 · 2023-08-07T12:01:25.000-04:00
The docstring for uart_cmsdk_apb_irq_rx_ready says "@return 1 if an interrupt is ready, 0 otherwise" but the function actually returns 2 on success. This commit fixes this to conform with serial driver API. Signed-off-by: Jason Mitchell <jmitchell@radicalsemiconductor.com>
diff --git a/drivers/serial/uart_cmsdk_apb.c b/drivers/serial/uart_cmsdk_apb.c
@@ -369,7 +369,7 @@ static int uart_cmsdk_apb_irq_rx_ready(const struct device *dev)
 {
 	const struct uart_cmsdk_apb_config *dev_cfg = dev->config;
 
-	return dev_cfg->uart->state & UART_RX_BF;
+	return (dev_cfg->uart->state & UART_RX_BF) == UART_RX_BF;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ static int uart_cmsdk_apb_irq_rx_ready(const struct device *dev)`
`369`	`369`	`{`
`370`	`370`	`const struct uart_cmsdk_apb_config *dev_cfg = dev->config;`
`371`	`371`
`372`		`- return dev_cfg->uart->state & UART_RX_BF;`
	`372`	`+ return (dev_cfg->uart->state & UART_RX_BF) == UART_RX_BF;`
`373`	`373`	`}`
`374`	`374`
`375`	`375`	`/**`