Skip to content

Commit 7541742

Browse files
tomasixyskartben
authored andcommitted
net: lib: ptp: Assert statements inverted
The asserts always fail because the condition is inverted. This patch fixes the condition to verify the socket is lower than PTP_SOCKET_CNT. Signed-off-by: Tomas Choat <[email protected]>
1 parent b3505fb commit 7541742

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

subsys/net/lib/ptp/transport.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ int ptp_transport_close(struct ptp_port *port)
266266

267267
int ptp_transport_send(struct ptp_port *port, struct ptp_msg *msg, enum ptp_socket idx)
268268
{
269-
__ASSERT(PTP_SOCKET_CNT <= idx, "Invalid socket index");
269+
__ASSERT(PTP_SOCKET_CNT > idx, "Invalid socket index");
270270

271271
static const int socket_port[] = {PTP_SOCKET_PORT_EVENT, PTP_SOCKET_PORT_GENERAL};
272272
int length = ntohs(msg->header.msg_length);
@@ -276,7 +276,7 @@ int ptp_transport_send(struct ptp_port *port, struct ptp_msg *msg, enum ptp_sock
276276

277277
int ptp_transport_sendto(struct ptp_port *port, struct ptp_msg *msg, enum ptp_socket idx)
278278
{
279-
__ASSERT(PTP_SOCKET_CNT <= idx, "Invalid socket index");
279+
__ASSERT(PTP_SOCKET_CNT > idx, "Invalid socket index");
280280

281281
static const int socket_port[] = {PTP_SOCKET_PORT_EVENT, PTP_SOCKET_PORT_GENERAL};
282282
int length = ntohs(msg->header.msg_length);
@@ -286,7 +286,7 @@ int ptp_transport_sendto(struct ptp_port *port, struct ptp_msg *msg, enum ptp_so
286286

287287
int ptp_transport_recv(struct ptp_port *port, struct ptp_msg *msg, enum ptp_socket idx)
288288
{
289-
__ASSERT(PTP_SOCKET_CNT <= idx, "Invalid socket index");
289+
__ASSERT(PTP_SOCKET_CNT > idx, "Invalid socket index");
290290

291291
int cnt = 0;
292292
uint8_t ctrl[CMSG_SPACE(sizeof(struct net_ptp_time))] = {0};

0 commit comments

Comments
 (0)