net_buf: buf: remove custom assertion logic

There is no need for a custom assert macro that is only used once, or
conditional compilation of the assert macro based on `__ASSERT_ON`. If
assertions are disabled the compiler should simply discard the code.

Signed-off-by: Jordan Yates <[email protected]>

Author: JordanYates

lib/net_buf/buf.c

@@ -34,8 +34,6 @@ LOG_MODULE_REGISTER(LOG_MODULE_NAME);
 #define NET_BUF_INFO(fmt, ...)
 #endif /* CONFIG_NET_BUF_LOG */
 
-#define NET_BUF_ASSERT(cond, ...) __ASSERT(cond, "" __VA_ARGS__)
-
 #if CONFIG_NET_BUF_WARN_ALLOC_INTERVAL > 0
 #define WARN_ALLOC_INTERVAL K_SECONDS(CONFIG_NET_BUF_WARN_ALLOC_INTERVAL)
 #else
@@ -331,9 +329,8 @@ struct net_buf *net_buf_alloc_len(struct net_buf_pool *pool, size_t size,
 	NET_BUF_DBG("allocated buf %p", buf);
 
 	if (size) {
-#if __ASSERT_ON
-		size_t req_size = size;
-#endif
+		__maybe_unused size_t req_size = size;
+
 		timeout = sys_timepoint_timeout(end);
 		buf->__buf = data_alloc(buf, &size, timeout);
 		if (!buf->__buf) {
@@ -343,9 +340,7 @@ struct net_buf *net_buf_alloc_len(struct net_buf_pool *pool, size_t size,
 			return NULL;
 		}
 
-#if __ASSERT_ON
-		NET_BUF_ASSERT(req_size <= size);
-#endif
+		__ASSERT_NO_MSG(req_size <= size);
 	} else {
 		buf->__buf = NULL;
 	}