posix: pthread: embed posix_thread_attr inside of posix_thread

Rather than shadowing most of the fields from pthread_attr_t
(struct posix_thread_attr) inside of struct posix_thread, just
embed the structure itself.

Additionally, use pthread_attr_init() to allocate a thread
stack and pthread_attr_destroy() to destroy a thread stack,
dramatically simplifying pthread_create().

A fair bit of rework was needed already to mitigate bitrot
issues in the testsuite. More should probably be done later.

Signed-off-by: Christopher Friedt <[email protected]>

Author: Christopher Friedt

lib/posix/posix_internal.h

@@ -29,8 +29,13 @@ struct posix_thread_attr {
 	uint16_t guardsize : CONFIG_POSIX_PTHREAD_ATTR_GUARDSIZE_BITS;
 	int8_t priority;
 	uint8_t schedpolicy: 2;
-	bool initialized: 1;
+	union {
+		bool caller_destroys: 1;
+		bool initialized: 1;
+	};
+	bool cancelpending: 1;
 	bool cancelstate: 1;
+	bool canceltype: 1;
 	bool detachstate: 1;
 };
 
@@ -46,23 +51,15 @@ struct posix_thread {
 	/* List of keys that thread has called pthread_setspecific() on */
 	sys_slist_t key_list;
 
-	/* Dynamic stack */
-	k_thread_stack_t *dynamic_stack;
+	/* pthread_attr_t */
+	struct posix_thread_attr attr;
 
 	/* Exit status */
 	void *retval;
 
 	/* Signal mask */
 	sigset_t sigset;
 
-	/* Pthread cancellation */
-	uint8_t cancel_state;
-	uint8_t cancel_type;
-	bool cancel_pending;
-
-	/* Detach state */
-	uint8_t detachstate;
-
 	/* Queue ID (internal-only) */
 	uint8_t qid;
 };