Skip to content

Commit 77fc356

Browse files
de-nordiccarlescufi
authored andcommitted
tests/mgmt/mcumgr/smp_reassembly: Drop zephyr_ prefix
The mcumgr transport API drops zephyr_ prefixes. Signed-off-by: Dominik Ermel <[email protected]>
1 parent 71e498d commit 77fc356

File tree

1 file changed

+25
-25
lines changed
  • tests/subsys/mgmt/mcumgr/smp_reassembly/src

1 file changed

+25
-25
lines changed

tests/subsys/mgmt/mcumgr/smp_reassembly/src/main.c

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -12,61 +12,61 @@
1212
#include <mgmt/mgmt.h>
1313
#include "../../../../../../subsys/mgmt/mcumgr/smp_reassembly.h"
1414

15-
static struct zephyr_smp_transport zst;
15+
static struct smp_transport smpt;
1616
static uint8_t buff[CONFIG_MCUMGR_BUF_SIZE];
1717
#define TEST_FRAME_SIZE 256
1818

1919
static struct net_buf *backup;
2020

21-
/* The function is called by zephyr_smp_reassembly_complete to pass a completed packet
21+
/* The function is called by smp_reassembly_complete to pass a completed packet
2222
* for further processing; since there is nothing to process, this stub will only backup
2323
* buffer the pointer to allow a test case to free it with use of the mcumgr net_buf
2424
* management.
2525
*/
26-
void zephyr_smp_rx_req(struct zephyr_smp_transport *zst, struct net_buf *nb)
26+
void smp_rx_req(struct smp_transport *smpt, struct net_buf *nb)
2727
{
2828
backup = nb;
2929
}
3030

3131
ZTEST(smp_reassembly, test_first)
3232
{
33-
zephyr_smp_reassembly_init(&zst);
33+
smp_reassembly_init(&smpt);
3434
struct mgmt_hdr *mh = (struct mgmt_hdr *)buff;
3535
int frag_used;
3636
int ret;
3737
int expected;
3838

3939
/** First fragment errors **/
4040
/* Len longer than netbuf error */
41-
zassert_equal(-ENOSR, zephyr_smp_reassembly_collect(&zst, buff, CONFIG_MCUMGR_BUF_SIZE + 1),
41+
zassert_equal(-ENOSR, smp_reassembly_collect(&smpt, buff, CONFIG_MCUMGR_BUF_SIZE + 1),
4242
"Expected -ENOSR error");
4343
/* Len not enough to read expected size from header */
4444
zassert_equal(-ENODATA,
45-
zephyr_smp_reassembly_collect(&zst, buff, sizeof(struct mgmt_hdr) - 1),
45+
smp_reassembly_collect(&smpt, buff, sizeof(struct mgmt_hdr) - 1),
4646
"Expected -ENODATA error");
4747
/* Length extracted from header, plus size of header, is bigger than buffer */
4848
mh->nh_len = sys_cpu_to_be16(CONFIG_MCUMGR_BUF_SIZE - sizeof(struct mgmt_hdr) + 1);
4949
zassert_equal(-ENOSR,
50-
zephyr_smp_reassembly_collect(&zst, buff, sizeof(struct mgmt_hdr) + 1),
50+
smp_reassembly_collect(&smpt, buff, sizeof(struct mgmt_hdr) + 1),
5151
"Expected -ENOSR error");
5252

5353
/* Successfully alloc buffer */
5454
mh->nh_len = sys_cpu_to_be16(TEST_FRAME_SIZE - sizeof(struct mgmt_hdr));
5555
frag_used = 40;
5656
expected = TEST_FRAME_SIZE - frag_used;
57-
ret = zephyr_smp_reassembly_collect(&zst, buff, frag_used);
57+
ret = smp_reassembly_collect(&smpt, buff, frag_used);
5858
zassert_equal(expected, ret,
5959
"Expected is %d should be %d\n", ret, expected);
6060

6161
/* Force complete it, expected returned number of bytes missing */
62-
ret = zephyr_smp_reassembly_complete(&zst, true);
62+
ret = smp_reassembly_complete(&smpt, true);
6363
zassert_equal(expected, ret,
6464
"Forced completion ret %d, but expected was %d\n", ret, expected);
6565

6666
/* Check fail due to lack of buffers: there is only one buffer and it already got passed
6767
* for processing by complete
6868
*/
69-
ret = zephyr_smp_reassembly_collect(&zst, buff, frag_used);
69+
ret = smp_reassembly_collect(&smpt, buff, frag_used);
7070
zassert_equal(-ENOMEM, ret,
7171
"Expected is %d should be %d\n", ret, expected);
7272

@@ -88,11 +88,11 @@ ZTEST(smp_reassembly, test_drops)
8888
mh->nh_len = sys_cpu_to_be16(TEST_FRAME_SIZE - sizeof(struct mgmt_hdr));
8989
frag_used = 40;
9090
expected = TEST_FRAME_SIZE - frag_used;
91-
ret = zephyr_smp_reassembly_collect(&zst, buff, frag_used);
91+
ret = smp_reassembly_collect(&smpt, buff, frag_used);
9292
zassert_equal(expected, ret,
9393
"Expected is %d should be %d\n", ret, expected);
9494

95-
ret = zephyr_smp_reassembly_drop(&zst);
95+
ret = smp_reassembly_drop(&smpt);
9696
zassert_equal(0, ret,
9797
"Expected %d from drop, got %d", ret, expected);
9898
}
@@ -114,37 +114,37 @@ ZTEST(smp_reassembly, test_collection)
114114
/* First fragment with header */
115115
mh->nh_len = sys_cpu_to_be16(TEST_FRAME_SIZE - sizeof(struct mgmt_hdr));
116116
frag = 40;
117-
ret = zephyr_smp_reassembly_collect(&zst, buff, frag);
117+
ret = smp_reassembly_collect(&smpt, buff, frag);
118118
expected = TEST_FRAME_SIZE - frag;
119119
zassert_equal(expected, ret,
120120
"Expected is %d should be %d\n", ret, expected);
121121
pkt_used = frag;
122122

123123
/* Next fragment */
124124
frag = 40;
125-
ret = zephyr_smp_reassembly_collect(&zst, &buff[pkt_used], frag);
125+
ret = smp_reassembly_collect(&smpt, &buff[pkt_used], frag);
126126
pkt_used += frag;
127127
expected = TEST_FRAME_SIZE - pkt_used;
128128
zassert_equal(expected, ret,
129129
"Expected is %d should be %d\n", ret, expected);
130130

131131
/* Try to complete incomplete, no force */
132-
ret = zephyr_smp_reassembly_complete(&zst, false);
132+
ret = smp_reassembly_complete(&smpt, false);
133133
zassert_equal(-ENODATA, ret,
134134
"Expected -ENODATA when completing incomplete buffer");
135135

136136
/* Last fragment */
137-
ret = zephyr_smp_reassembly_collect(&zst, &buff[pkt_used], expected);
137+
ret = smp_reassembly_collect(&smpt, &buff[pkt_used], expected);
138138
zassert_equal(0, ret,
139139
"Expected is %d should be %d\n", ret, 0);
140140

141141
/* And overflow */
142-
ret = zephyr_smp_reassembly_collect(&zst, buff, 1);
142+
ret = smp_reassembly_collect(&smpt, buff, 1);
143143
zassert_equal(-EOVERFLOW, ret,
144144
"Expected -EOVERFLOW, got %d\n", ret);
145145

146146
/* Complete successfully complete buffer */
147-
ret = zephyr_smp_reassembly_complete(&zst, false);
147+
ret = smp_reassembly_complete(&smpt, false);
148148
zassert_equal(0, ret,
149149
"Expected 0 from complete, got %d\n", ret);
150150

@@ -164,15 +164,15 @@ ZTEST(smp_reassembly, test_no_packet_started)
164164
int ret;
165165

166166
/** Complete on non-started packet **/
167-
ret = zephyr_smp_reassembly_complete(&zst, false);
167+
ret = smp_reassembly_complete(&smpt, false);
168168
zassert_equal(-EINVAL, ret,
169169
"Expected -EINVAL from complete, got %d", ret);
170-
ret = zephyr_smp_reassembly_complete(&zst, true);
170+
ret = smp_reassembly_complete(&smpt, true);
171171
zassert_equal(-EINVAL, ret,
172172
"Expected -EINVAL from complete, got %d", ret);
173173

174174
/* Try to drop packet when there is none yet */
175-
ret = zephyr_smp_reassembly_drop(&zst);
175+
ret = smp_reassembly_drop(&smpt);
176176
zassert_equal(-EINVAL, ret,
177177
"Expected -EINVAL, there is no packet started yet");
178178
}
@@ -186,20 +186,20 @@ ZTEST(smp_reassembly, test_ud)
186186
void *p;
187187

188188
/* No packet started yet */
189-
p = zephyr_smp_reassembly_get_ud(&zst);
189+
p = smp_reassembly_get_ud(&smpt);
190190
zassert_equal(p, NULL, "Expect NULL ud poiner");
191191

192192
/* After collecting first fragment */
193193
mh->nh_len = sys_cpu_to_be16(TEST_FRAME_SIZE);
194194
frag_used = 40;
195195
expected = TEST_FRAME_SIZE - frag_used + sizeof(struct mgmt_hdr);
196-
ret = zephyr_smp_reassembly_collect(&zst, buff, frag_used);
196+
ret = smp_reassembly_collect(&smpt, buff, frag_used);
197197
zassert_equal(expected, ret,
198198
"Expected is %d should be %d\n", ret, expected);
199199

200-
p = zephyr_smp_reassembly_get_ud(&zst);
200+
p = smp_reassembly_get_ud(&smpt);
201201
zassert_not_equal(p, NULL, "Expect non-NULL ud poiner");
202-
zephyr_smp_reassembly_drop(&zst);
202+
smp_reassembly_drop(&smpt);
203203
}
204204

205205
ZTEST_SUITE(smp_reassembly, NULL, NULL, NULL, NULL, NULL);

0 commit comments

Comments
 (0)