Skip to content

Commit 79713a5

Browse files
decsnydanieldegrasse
authored andcommitted
soc: imxrt11xx: Clean up LDO configs
The LDO config should not be forcefully selected at SOC level. Instead, use soft default y so that board definition can unset it if desired. Also, in the soc.c, the LDO code should be on both the rt1160 and rt1170, so the definitions should exist, and ifdef is not needed. So can switch to IS_ENABLED to decrease configuration complexity of the source code. Signed-off-by: Declan Snyder <[email protected]>
1 parent 305a7e6 commit 79713a5

File tree

2 files changed

+21
-21
lines changed

2 files changed

+21
-21
lines changed

soc/nxp/imxrt/imxrt11xx/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ config SOC_SERIES_IMXRT11XX
2929
select CPU_HAS_DCACHE if CPU_CORTEX_M7
3030
select CPU_HAS_FPU
3131
select CPU_HAS_FPU_DOUBLE_PRECISION if CPU_CORTEX_M7
32-
select BYPASS_LDO_LPSR
33-
select ADJUST_LDO
3432
select HAS_MCUX_PWM
3533
select HAS_MCUX_USDHC1
3634
select HAS_MCUX_USDHC2
@@ -62,9 +60,11 @@ config MCUX_CORE_SUFFIX
6260
default "_cm4" if SOC_MIMXRT1176_CM4 || SOC_MIMXRT1166_CM4
6361

6462
config BYPASS_LDO_LPSR
63+
default y
6564
bool "Bypass LDO lpsr"
6665

6766
config ADJUST_LDO
67+
default y
6868
bool "Adjust LDO setting"
6969

7070
endif # SOC_SERIES_IMXRT11XX

soc/nxp/imxrt/imxrt11xx/soc.c

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -147,28 +147,28 @@ __weak void clock_init(void)
147147
}
148148
#endif
149149

150-
#if CONFIG_BYPASS_LDO_LPSR
151-
PMU_StaticEnableLpsrAnaLdoBypassMode(ANADIG_LDO_SNVS, true);
152-
PMU_StaticEnableLpsrDigLdoBypassMode(ANADIG_LDO_SNVS, true);
153-
#endif
154-
155-
#if CONFIG_ADJUST_LDO
156-
pmu_static_lpsr_ana_ldo_config_t lpsrAnaConfig;
157-
pmu_static_lpsr_dig_config_t lpsrDigConfig;
158-
159-
if ((ANADIG_LDO_SNVS->PMU_LDO_LPSR_ANA &
160-
ANADIG_LDO_SNVS_PMU_LDO_LPSR_ANA_BYPASS_MODE_EN_MASK) == 0UL) {
161-
PMU_StaticGetLpsrAnaLdoDefaultConfig(&lpsrAnaConfig);
162-
PMU_StaticLpsrAnaLdoInit(ANADIG_LDO_SNVS, &lpsrAnaConfig);
150+
if (IS_ENABLED(CONFIG_BYPASS_LDO_LPSR)) {
151+
PMU_StaticEnableLpsrAnaLdoBypassMode(ANADIG_LDO_SNVS, true);
152+
PMU_StaticEnableLpsrDigLdoBypassMode(ANADIG_LDO_SNVS, true);
163153
}
164154

165-
if ((ANADIG_LDO_SNVS->PMU_LDO_LPSR_DIG &
166-
ANADIG_LDO_SNVS_PMU_LDO_LPSR_DIG_BYPASS_MODE_MASK) == 0UL) {
167-
PMU_StaticGetLpsrDigLdoDefaultConfig(&lpsrDigConfig);
168-
lpsrDigConfig.targetVoltage = kPMU_LpsrDigTargetStableVoltage1P117V;
169-
PMU_StaticLpsrDigLdoInit(ANADIG_LDO_SNVS, &lpsrDigConfig);
155+
if (IS_ENABLED(CONFIG_ADJUST_LDO)) {
156+
pmu_static_lpsr_ana_ldo_config_t lpsrAnaConfig;
157+
pmu_static_lpsr_dig_config_t lpsrDigConfig;
158+
159+
if ((ANADIG_LDO_SNVS->PMU_LDO_LPSR_ANA &
160+
ANADIG_LDO_SNVS_PMU_LDO_LPSR_ANA_BYPASS_MODE_EN_MASK) == 0UL) {
161+
PMU_StaticGetLpsrAnaLdoDefaultConfig(&lpsrAnaConfig);
162+
PMU_StaticLpsrAnaLdoInit(ANADIG_LDO_SNVS, &lpsrAnaConfig);
163+
}
164+
165+
if ((ANADIG_LDO_SNVS->PMU_LDO_LPSR_DIG &
166+
ANADIG_LDO_SNVS_PMU_LDO_LPSR_DIG_BYPASS_MODE_MASK) == 0UL) {
167+
PMU_StaticGetLpsrDigLdoDefaultConfig(&lpsrDigConfig);
168+
lpsrDigConfig.targetVoltage = kPMU_LpsrDigTargetStableVoltage1P117V;
169+
PMU_StaticLpsrDigLdoInit(ANADIG_LDO_SNVS, &lpsrDigConfig);
170+
}
170171
}
171-
#endif
172172

173173
/* PLL LDO shall be enabled first before enable PLLs */
174174

0 commit comments

Comments
 (0)