pm: Remove unused parameter

Flavio Ceolin · cfriedt · commit 7dd429721415 · 2021-11-17T11:15:49.000-05:00
The number of ticks on z_pm_save_idle_exit is not used and there is
no need to have it.

Signed-off-by: Flavio Ceolin &lt;flavio.ceolin@intel.com&gt;
diff --git a/arch/arc/core/isr_wrapper.S b/arch/arc/core/isr_wrapper.S
@@ -249,8 +249,6 @@ rirq_path:
 #if defined(CONFIG_PM)
 	clri r0 /* do not interrupt exiting tickless idle operations */
 	MOVR r1, _kernel
-	/* z_kernel.idle is 32 bit despite of platform bittnes */
-	ld_s r3, [r1, _kernel_offset_to_idle] /* requested idle duration */
 	breq r3, 0, _skip_pm_save_idle_exit
 
 	st 0, [r1, _kernel_offset_to_idle] /* zero idle duration */
diff --git a/arch/arm/core/aarch32/irq_manage.c b/arch/arm/core/aarch32/irq_manage.c
@@ -181,10 +181,8 @@ void _arch_isr_direct_pm(void)
 #endif /* CONFIG_ARMV6_M_ARMV8_M_BASELINE */
 
 	if (_kernel.idle) {
-		int32_t idle_val = _kernel.idle;
-
 		_kernel.idle = 0;
-		z_pm_save_idle_exit(idle_val);
+		z_pm_save_idle_exit();
 	}
 
 #if defined(CONFIG_ARMV6_M_ARMV8_M_BASELINE) \
diff --git a/arch/posix/core/swap.c b/arch/posix/core/swap.c
@@ -111,10 +111,8 @@ void arch_switch_to_main_thread(struct k_thread *main_thread, char *stack_ptr,
 void posix_irq_check_idle_exit(void)
 {
 	if (_kernel.idle) {
-		int32_t idle_val = _kernel.idle;
-
 		_kernel.idle = 0;
-		z_pm_save_idle_exit(idle_val);
+		z_pm_save_idle_exit();
 	}
 }
 #endif
diff --git a/arch/x86/core/ia32/intstub.S b/arch/x86/core/ia32/intstub.S
@@ -301,8 +301,6 @@ nestedInterrupt:
 handle_idle:
 	pushl	%eax
 	pushl	%edx
-	/* Populate 'ticks' argument to z_pm_save_idle_exit */
-	push	_kernel_offset_to_idle(%ecx)
 	/* Zero out _kernel.idle */
 	movl	$0, _kernel_offset_to_idle(%ecx)
 
@@ -314,8 +312,6 @@ handle_idle:
 	 */
 
 	call	z_pm_save_idle_exit
-	/* discard 'ticks' argument passed on the stack */
-	add	$0x4, %esp
 	popl	%edx
 	popl	%eax
 	jmp	alreadyOnIntStack
diff --git a/include/arch/x86/ia32/arch.h b/include/arch/x86/ia32/arch.h
@@ -244,10 +244,8 @@ typedef struct s_isrList {
 static inline void arch_irq_direct_pm(void)
 {
 	if (_kernel.idle) {
-		int32_t idle_val = _kernel.idle;
-
 		_kernel.idle = 0;
-		z_pm_save_idle_exit(idle_val);
+		z_pm_save_idle_exit();
 	}
 }
 
diff --git a/include/pm/pm.h b/include/pm/pm.h
@@ -215,7 +215,7 @@ void pm_power_state_exit_post_ops(struct pm_state_info info);
 
 #endif /* CONFIG_PM */
 
-void z_pm_save_idle_exit(int32_t ticks);
+void z_pm_save_idle_exit(void);
 
 #ifdef __cplusplus
 }
diff --git a/kernel/idle.c b/kernel/idle.c
@@ -48,7 +48,7 @@ static void pm_save_idle(void)
 #endif
 }
 
-void z_pm_save_idle_exit(int32_t ticks)
+void z_pm_save_idle_exit(void)
 {
 #ifdef CONFIG_PM
 	/* Some CPU low power states require notification at the ISR

Original file line number	Diff line number	Diff line change
`@@ -111,10 +111,8 @@ void arch_switch_to_main_thread(struct k_thread main_thread, char stack_ptr,`
`111`	`111`	`void posix_irq_check_idle_exit(void)`
`112`	`112`	`{`
`113`	`113`	`if (_kernel.idle) {`
`114`		`- int32_t idle_val = _kernel.idle;`
`115`		`-`
`116`	`114`	`_kernel.idle = 0;`
`117`		`- z_pm_save_idle_exit(idle_val);`
	`115`	`+ z_pm_save_idle_exit();`
`118`	`116`	`}`
`119`	`117`	`}`
`120`	`118`	`#endif`
Original file line number	Diff line number	Diff line change
`@@ -244,10 +244,8 @@ typedef struct s_isrList {`
`244`	`244`	`static inline void arch_irq_direct_pm(void)`
`245`	`245`	`{`
`246`	`246`	`if (_kernel.idle) {`
`247`		`- int32_t idle_val = _kernel.idle;`
`248`		`-`
`249`	`247`	`_kernel.idle = 0;`
`250`		`- z_pm_save_idle_exit(idle_val);`
	`248`	`+ z_pm_save_idle_exit();`
`251`	`249`	`}`
`252`	`250`	`}`
`253`	`251`
Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ void pm_power_state_exit_post_ops(struct pm_state_info info);`
`215`	`215`
`216`	`216`	`#endif /* CONFIG_PM */`
`217`	`217`
`218`		`-void z_pm_save_idle_exit(int32_t ticks);`
	`218`	`+void z_pm_save_idle_exit(void);`
`219`	`219`
`220`	`220`	`#ifdef __cplusplus`
`221`	`221`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ static void pm_save_idle(void)`
`48`	`48`	`#endif`
`49`	`49`	`}`
`50`	`50`
`51`		`-void z_pm_save_idle_exit(int32_t ticks)`
	`51`	`+void z_pm_save_idle_exit(void)`
`52`	`52`	`{`
`53`	`53`	`#ifdef CONFIG_PM`
`54`	`54`	`/* Some CPU low power states require notification at the ISR`