Bluetooth: Host: Add "assert non-null" to bt_conn_ref

alwa-nordic · fabiobaltieri · commit 7e11b98125c6 · 2022-09-20T08:22:28.000Z
Clearly `conn` must be non-null since it's dereferenced without checks.

Signed-off-by: Aleksander Wasaznik &lt;aleksander.wasaznik@nordicsemi.no&gt;
diff --git a/subsys/bluetooth/host/conn.c b/subsys/bluetooth/host/conn.c
@@ -1120,6 +1120,8 @@ struct bt_conn *bt_conn_ref(struct bt_conn *conn)
 {
 	atomic_val_t old;
 
+	__ASSERT_NO_MSG(conn);
+
 	/* Reference counter must be checked to avoid incrementing ref from
 	 * zero, then we should return NULL instead.
 	 * Loop on clear-and-set in case someone has modified the reference

Original file line number	Diff line number	Diff line change
`@@ -1120,6 +1120,8 @@ struct bt_conn bt_conn_ref(struct bt_conn conn)`
`1120`	`1120`	`{`
`1121`	`1121`	`atomic_val_t old;`
`1122`	`1122`
	`1123`	`+ __ASSERT_NO_MSG(conn);`
	`1124`	`+`
`1123`	`1125`	`/* Reference counter must be checked to avoid incrementing ref from`
`1124`	`1126`	`* zero, then we should return NULL instead.`
`1125`	`1127`	`* Loop on clear-and-set in case someone has modified the reference`