Skip to content

Commit 7e63be1

Browse files
finikorgcarlescufi
authored andcommitted
bluetooth: shell: Fix NULL dereference
Fix NULL dereference when dereferencing txing_stream, which was used instead of default_stream. Signed-off-by: Andrei Emeltchenko <[email protected]>
1 parent c6c5d58 commit 7e63be1

File tree

1 file changed

+7
-7
lines changed
  • subsys/bluetooth/shell

1 file changed

+7
-7
lines changed

subsys/bluetooth/shell/bap.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2291,22 +2291,22 @@ static int cmd_send(const struct shell *sh, size_t argc, char *argv[])
22912291
return -ENOEXEC;
22922292
}
22932293

2294-
if (txing_stream->qos == NULL) {
2294+
if (default_stream->qos == NULL) {
22952295
shell_error(sh, "NULL stream QoS");
22962296

22972297
return -ENOEXEC;
22982298
}
22992299

23002300
if (argc > 1) {
23012301
len = hex2bin(argv[1], strlen(argv[1]), data, sizeof(data));
2302-
if (len > txing_stream->qos->sdu) {
2302+
if (len > default_stream->qos->sdu) {
23032303
shell_print(sh, "Unable to send: len %d > %u MTU",
2304-
len, txing_stream->qos->sdu);
2304+
len, default_stream->qos->sdu);
23052305

23062306
return -ENOEXEC;
23072307
}
23082308
} else {
2309-
len = MIN(txing_stream->qos->sdu, sizeof(data));
2309+
len = MIN(default_stream->qos->sdu, sizeof(data));
23102310
memset(data, 0xff, len);
23112311
}
23122312

@@ -2315,10 +2315,10 @@ static int cmd_send(const struct shell *sh, size_t argc, char *argv[])
23152315

23162316
net_buf_add_mem(buf, data, len);
23172317

2318-
seq_num = get_next_seq_num(txing_stream->qos->interval);
2318+
seq_num = get_next_seq_num(default_stream->qos->interval);
23192319

2320-
ret = bt_bap_stream_send(txing_stream, buf, seq_num,
2321-
BT_ISO_TIMESTAMP_NONE);
2320+
ret = bt_bap_stream_send(default_stream, buf, seq_num,
2321+
BT_ISO_TIMESTAMP_NONE);
23222322
if (ret < 0) {
23232323
shell_print(sh, "Unable to send: %d", -ret);
23242324
net_buf_unref(buf);

0 commit comments

Comments
 (0)