Skip to content

Commit 8279489

Browse files
Juha Heiskanencarlescufi
authored andcommitted
net: lwm2m: RD Client update registration timeout
Renamed LWM2M_RD_CLIENT_EVENT_REG_UPDATE_FAILURE to LWM2M_RD_CLIENT_EVENT_REG_TIMEOUT. Changed reported event type for registration timeout to LWM2M_RD_CLIENT_EVENT_REG_TIMEOUT from LWM2M_RD_CLIENT_EVENT_REGISTRATION_FAILURE. LWM2M_RD_CLIENT_EVENT_REGISTRATION_FAILURE should be only reported case when server reject by response registration. Signed-off-by: Juha Heiskanen <[email protected]>
1 parent bd3bc98 commit 8279489

File tree

4 files changed

+18
-12
lines changed

4 files changed

+18
-12
lines changed

doc/connectivity/networking/api/lwm2m.rst

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -302,8 +302,8 @@ events, setup a callback function:
302302
LOG_DBG("Registration complete");
303303
break;
304304
305-
case LWM2M_RD_CLIENT_EVENT_REG_UPDATE_FAILURE:
306-
LOG_DBG("Registration update failure!");
305+
case LWM2M_RD_CLIENT_EVENT_REG_TIMEOUT:
306+
LOG_DBG("Registration timeout!");
307307
break;
308308
309309
case LWM2M_RD_CLIENT_EVENT_REG_UPDATE_COMPLETE:
@@ -472,7 +472,7 @@ The events are prefixed with ``LWM2M_RD_CLIENT_EVENT_``.
472472
* - 4
473473
- REGISTRATION_FAILURE
474474
- Registration to LwM2M server failed.
475-
Occurs if there is a timeout or failure in the registration.
475+
Occurs if there is a failure in the registration.
476476
- Retry registration
477477
* - 5
478478
- REGISTRATION_COMPLETE
@@ -481,10 +481,10 @@ The events are prefixed with ``LWM2M_RD_CLIENT_EVENT_``.
481481
or when session resumption is used.
482482
- No actions needed
483483
* - 6
484-
- REG_UPDATE_FAILURE
485-
- Registration update failed.
486-
Occurs if there is a timeout during registration update.
487-
NOTE: If registration update fails without a timeout,
484+
- REG_TIMEOUT
485+
- Registration or registration update timeout.
486+
Occurs if there is a timeout during registration.
487+
NOTE: If registration fails without a timeout,
488488
a full registration is triggered automatically and
489489
no registration update failure event is generated.
490490
- No actions needed, client proceeds to re-registration automatically.

include/zephyr/net/lwm2m.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1252,7 +1252,7 @@ enum lwm2m_rd_client_event {
12521252
LWM2M_RD_CLIENT_EVENT_BOOTSTRAP_TRANSFER_COMPLETE,
12531253
LWM2M_RD_CLIENT_EVENT_REGISTRATION_FAILURE,
12541254
LWM2M_RD_CLIENT_EVENT_REGISTRATION_COMPLETE,
1255-
LWM2M_RD_CLIENT_EVENT_REG_UPDATE_FAILURE,
1255+
LWM2M_RD_CLIENT_EVENT_REG_TIMEOUT,
12561256
LWM2M_RD_CLIENT_EVENT_REG_UPDATE_COMPLETE,
12571257
LWM2M_RD_CLIENT_EVENT_DEREGISTER_FAILURE,
12581258
LWM2M_RD_CLIENT_EVENT_DISCONNECT,
@@ -1261,6 +1261,12 @@ enum lwm2m_rd_client_event {
12611261
LWM2M_RD_CLIENT_EVENT_NETWORK_ERROR,
12621262
};
12631263

1264+
/**
1265+
* Define for old event name keeping backward compatibility.
1266+
*/
1267+
#define LWM2M_RD_CLIENT_EVENT_REG_UPDATE_FAILURE \
1268+
LWM2M_RD_CLIENT_EVENT_REG_TIMEOUT __DEPRECATED_MACRO
1269+
12641270
/*
12651271
* LwM2M RD client flags, used to configure LwM2M session.
12661272
*/

samples/net/lwm2m_client/src/lwm2m-client.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -446,8 +446,8 @@ static void rd_client_event(struct lwm2m_ctx *client,
446446
LOG_DBG("Registration complete");
447447
break;
448448

449-
case LWM2M_RD_CLIENT_EVENT_REG_UPDATE_FAILURE:
450-
LOG_DBG("Registration update failure!");
449+
case LWM2M_RD_CLIENT_EVENT_REG_TIMEOUT:
450+
LOG_DBG("Registration timeout!");
451451
break;
452452

453453
case LWM2M_RD_CLIENT_EVENT_REG_UPDATE_COMPLETE:

subsys/net/lib/lwm2m/lwm2m_rd_client.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,9 @@ static void sm_handle_timeout_state(struct lwm2m_message *msg,
259259
#endif
260260
{
261261
if (client.engine_state == ENGINE_REGISTRATION_SENT) {
262-
event = LWM2M_RD_CLIENT_EVENT_REGISTRATION_FAILURE;
262+
event = LWM2M_RD_CLIENT_EVENT_REG_TIMEOUT;
263263
} else if (client.engine_state == ENGINE_UPDATE_SENT) {
264-
event = LWM2M_RD_CLIENT_EVENT_REG_UPDATE_FAILURE;
264+
event = LWM2M_RD_CLIENT_EVENT_REG_TIMEOUT;
265265
} else if (client.engine_state == ENGINE_DEREGISTER_SENT) {
266266
event = LWM2M_RD_CLIENT_EVENT_DEREGISTER_FAILURE;
267267
} else {

0 commit comments

Comments
 (0)