drivers: ethernet: add check for null fragment before TX loop

In eth_cyclonev_send(), add a guard to detect if the net_pkt has no data
buffer (i.e., pkt->buffer is NULL) before starting the TX descriptor loop.

This prevents a potential null pointer dereference on frag->data in the
first iteration of the do-while loop.

The previous in-loop check for frag was redundant and misleading: it still
allowed access to frag->data even when frag could be NULL, making the code
both unnecessary and potentially unsafe.

The new check ensures frag is valid before entering the loop, covering the
rare case where net_pkt has no associated buffer.

Signed-off-by: Gaetan Perrot <[email protected]>

Author: moonlight83340

drivers/ethernet/eth_cyclonev.c

@@ -408,6 +408,9 @@ static int eth_cyclonev_send(const struct device *dev, struct net_pkt *pkt)
 
 	LOG_DBG("Pkt length: %d", len);
 	frag = pkt->buffer;
+
+	__ASSERT((frag != NULL), "Invalid net_pkt: no data buffer\n");
+
 	do {
 
 		/* reserve a free descriptor for this fragment */
@@ -433,10 +436,7 @@ static int eth_cyclonev_send(const struct device *dev, struct net_pkt *pkt)
 
 		/* Copy data to local buffer   */
 
-		if (frag) {
-			memcpy(&p->tx_buf[p->tx_current_desc_number * ETH_BUFFER_SIZE], frag->data,
-			       len);
-		}
+		memcpy(&p->tx_buf[p->tx_current_desc_number * ETH_BUFFER_SIZE], frag->data, len);
 
 		/* Set the buffer size.  */
 		tx_desc->control_buffer_size = (frag->len & ETH_DMATXDESC_TBS1);