Bluetooth: Controller: Remove redundant local variable

andrzej-kaczmarek · andrzej-kaczmarek · commit 844712fb291c · 2021-08-27T15:43:59.000+02:00
'err' is already defined in parent scope, we can use. Just need to set
it back to 0 before returning from function.

Signed-off-by: Andrzej Kaczmarek &lt;andrzej.kaczmarek@codecoup.pl&gt;
diff --git a/subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync.c b/subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync.c
@@ -516,13 +516,13 @@ static int isr_rx(struct lll_sync *lll, uint8_t node_type, uint8_t *trx_cnt,
 	}
 #if defined(CONFIG_BT_CTLR_DF_SAMPLE_CTE_FOR_PDU_WITH_BAD_CRC)
 	else {
-		int err;
-
 		err = create_iq_report(lll, rssi_ready,
 				       BT_HCI_LE_CTE_CRC_ERR_CTE_BASED_TIME);
 		if (!err) {
 			ull_rx_sched();
 		}
+
+		err = 0;
 	}
 #endif /* CONFIG_BT_CTLR_DF_SAMPLE_CTE_FOR_PDU_WITH_BAD_CRC */
 

Original file line number	Diff line number	Diff line change
`@@ -516,13 +516,13 @@ static int isr_rx(struct lll_sync lll, uint8_t node_type, uint8_t trx_cnt,`
`516`	`516`	`}`
`517`	`517`	`#if defined(CONFIG_BT_CTLR_DF_SAMPLE_CTE_FOR_PDU_WITH_BAD_CRC)`
`518`	`518`	`else {`
`519`		`- int err;`
`520`		`-`
`521`	`519`	`err = create_iq_report(lll, rssi_ready,`
`522`	`520`	`BT_HCI_LE_CTE_CRC_ERR_CTE_BASED_TIME);`
`523`	`521`	`if (!err) {`
`524`	`522`	`ull_rx_sched();`
`525`	`523`	`}`
	`524`	`+`
	`525`	`+ err = 0;`
`526`	`526`	`}`
`527`	`527`	`#endif /* CONFIG_BT_CTLR_DF_SAMPLE_CTE_FOR_PDU_WITH_BAD_CRC */`
`528`	`528`