tests: memory protect: add some error test cases

Add some error case for initializing memory domain and removing
memory partition.

Signed-off-by: Enjia Mai <[email protected]>

Author: Enjia Mai

tests/kernel/mem_protect/mem_protect/src/common.c

@@ -8,12 +8,16 @@
 
 ZTEST_BMEM volatile bool valid_fault;
 
+extern void post_fatal_error_handler(unsigned int reason, const z_arch_esf_t *pEsf);
+
 void k_sys_fatal_error_handler(unsigned int reason, const z_arch_esf_t *pEsf)
 {
 	printk("Caught system error -- reason %d %d\n", reason, valid_fault);
 	if (valid_fault) {
 		printk("fatal error expected as part of test case\n");
 		valid_fault = false; /* reset back to normal */
+
+		post_fatal_error_handler(reason, pEsf);
 	} else {
 		printk("fatal error was unexpected, aborting\n");
 		k_fatal_halt(reason);

tests/kernel/mem_protect/mem_protect/src/main.c

@@ -34,6 +34,8 @@ void test_main(void)
 		ztest_unit_test(test_mem_domain_boot_threads),
 		ztest_unit_test(test_mem_domain_migration),
 		ztest_unit_test(test_mem_part_overlap),
+		ztest_unit_test(test_mem_domain_init_fail),
+		ztest_unit_test(test_mem_domain_remove_part_fail),
 
 		/* mem_partition.c */
 		ztest_user_unit_test(test_mem_part_assign_bss_vars_zero),

tests/kernel/mem_protect/mem_protect/src/mem_domain.c

@@ -328,6 +328,9 @@ void test_mem_domain_migration(void)
 	printk("migrate to new domain\n");
 	k_mem_domain_add_thread(&test_domain, &child_thread);
 
+	/**TESTPOINT: add to existing domain will do nothing */
+	k_mem_domain_add_thread(&test_domain, &child_thread);
+
 	/* set spin_done so the child thread completes */
 	printk("set test completion\n");
 	spin_done = true;
@@ -346,7 +349,7 @@ void test_mem_domain_migration(void)
  * - System testing
  *
  * Prerequisite Conditions:
-* - N/A
+ * - N/A
  *
  * Input Specifications:
  * - N/A
@@ -379,3 +382,77 @@ void test_mem_part_overlap(void)
 
 	k_mem_domain_add_partition(&test_domain, &overlap_part);
 }
+
+
+extern struct k_spinlock z_mem_domain_lock;
+
+static ZTEST_BMEM bool need_recover_spinlock;
+
+static struct k_mem_domain test_domain_fail;
+
+void post_fatal_error_handler(unsigned int reason, const z_arch_esf_t *pEsf)
+{
+	if (need_recover_spinlock) {
+		k_spin_release(&z_mem_domain_lock);
+
+		need_recover_spinlock = false;
+	}
+}
+
+#if defined(CONFIG_ASSERT)
+static volatile uint8_t __aligned(MEM_REGION_ALLOC) misc_buf[MEM_REGION_ALLOC];
+K_MEM_PARTITION_DEFINE(find_no_part, misc_buf, sizeof(misc_buf),
+		       K_MEM_PARTITION_P_RO_U_RO);
+
+/**
+ * @brief Test error case of removing memory partition fail
+ *
+ * @details Try to remove a partition not in the domain will cause
+ * assertion, then triggher an expected fatal error.
+ * And while the fatal error happened, the memory domain spinlock
+ * is held, we need to release them to make other follow test case.
+ *
+ * @ingroup kernel_memprotect_tests
+ */
+void test_mem_domain_remove_part_fail(void)
+{
+	struct k_mem_partition *no_parts = &find_no_part;
+
+	need_recover_spinlock = true;
+	set_fault_valid(true);
+	k_mem_domain_remove_partition(&test_domain, no_parts);
+}
+#else
+void test_mem_domain_remove_part_fail(void)
+{
+	ztest_test_skip();
+}
+#endif
+
+/**
+ * @brief Test error case of initializing memory domain fail
+ *
+ * @details Try to initialize a domain with invalid partition, then see
+ * if an expected fatal error happens.
+ * And while the fatal error happened, the memory domain spinlock
+ * is held, we need to release them to make other follow test case.
+ *
+ * @ingroup kernel_memprotect_tests
+ */
+void test_mem_domain_init_fail(void)
+{
+	struct k_mem_partition *no_parts[] = {&ro_part, 0};
+
+	/* init another domain fail, expected fault happened */
+	need_recover_spinlock = true;
+	set_fault_valid(true);
+	k_mem_domain_init(&test_domain_fail, ARRAY_SIZE(no_parts),
+			no_parts);
+
+	/* For acrh which not CONFIG_ARCH_MEM_DOMAIN_DATA, if assert is off,
+	 * it will reach here.
+	 */
+#if !defined(CONFIG_ASSERT) && defined(CONFIG_ARCH_MEM_DOMAIN_DATA)
+	zassert_unreachable("should not be here");
+#endif
+}

tests/kernel/mem_protect/mem_protect/src/mem_protect.h

@@ -21,6 +21,8 @@ extern void test_mem_domain_remove_add_partition(void);
 extern void test_mem_domain_api_supervisor_only(void);
 extern void test_mem_domain_boot_threads(void);
 extern void test_mem_domain_migration(void);
+extern void test_mem_domain_init_fail(void);
+extern void test_mem_domain_remove_part_fail(void);
 
 extern void test_macros_obtain_names_data_bss(void);
 extern void test_mem_part_assign_bss_vars_zero(void);