Skip to content

Commit 865152f

Browse files
ndrs-pstkartben
authored andcommitted
bluetooth: host: gatt: consolidate net_buf_add call
Consolidate `net_buf_add` calls using known `param->len` to streamline the codebase. Signed-off-by: Pisit Sawangvonganan <[email protected]>
1 parent c616a17 commit 865152f

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

subsys/bluetooth/host/gatt.c

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2417,11 +2417,9 @@ static void gatt_add_nfy_to_buf(struct net_buf *buf,
24172417
{
24182418
struct bt_att_notify_mult *nfy;
24192419

2420-
nfy = net_buf_add(buf, sizeof(*nfy));
2420+
nfy = net_buf_add(buf, sizeof(*nfy) + params->len);
24212421
nfy->handle = sys_cpu_to_le16(handle);
24222422
nfy->len = sys_cpu_to_le16(params->len);
2423-
2424-
net_buf_add(buf, params->len);
24252423
(void)memcpy(nfy->value, params->data, params->len);
24262424
}
24272425

@@ -2532,10 +2530,8 @@ static int gatt_notify(struct bt_conn *conn, uint16_t handle,
25322530

25332531
LOG_DBG("conn %p handle 0x%04x", conn, handle);
25342532

2535-
nfy = net_buf_add(buf, sizeof(*nfy));
2533+
nfy = net_buf_add(buf, sizeof(*nfy) + params->len);
25362534
nfy->handle = sys_cpu_to_le16(handle);
2537-
2538-
net_buf_add(buf, params->len);
25392535
memcpy(nfy->value, params->data, params->len);
25402536

25412537
bt_att_set_tx_meta_data(buf, params->func, params->user_data, BT_ATT_CHAN_OPT(params));
@@ -2700,10 +2696,8 @@ static int gatt_indicate(struct bt_conn *conn, uint16_t handle,
27002696

27012697
bt_att_set_tx_meta_data(buf, NULL, NULL, BT_ATT_CHAN_OPT(params));
27022698

2703-
ind = net_buf_add(buf, sizeof(*ind));
2699+
ind = net_buf_add(buf, sizeof(*ind) + params->len);
27042700
ind->handle = sys_cpu_to_le16(handle);
2705-
2706-
net_buf_add(buf, params->len);
27072701
memcpy(ind->value, params->data, params->len);
27082702

27092703
LOG_DBG("conn %p handle 0x%04x", conn, handle);

0 commit comments

Comments
 (0)