Skip to content

Commit 8824f4a

Browse files
author
Jeppe Odgaard
committed
heap_listener: only use designated initializer
C++20 require that either all initializer clauses should be designated or none of them should be. Signed-off-by: Jeppe Odgaard <[email protected]>
1 parent cf282c4 commit 8824f4a

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

include/zephyr/sys/heap_listener.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,10 @@ struct heap_listener {
105105
enum heap_event_types event;
106106

107107
union {
108-
heap_listener_alloc_cb_t alloc_cb;
109-
heap_listener_free_cb_t free_cb;
110-
heap_listener_resize_cb_t resize_cb;
111-
};
108+
heap_listener_alloc_cb_t alloc;
109+
heap_listener_free_cb_t free;
110+
heap_listener_resize_cb_t resize;
111+
} cb;
112112
};
113113

114114
/**
@@ -206,7 +206,7 @@ void heap_listener_notify_resize(uintptr_t heap_id, void *old_heap_end, void *ne
206206
struct heap_listener name = { \
207207
.heap_id = _heap_id, \
208208
.event = HEAP_ALLOC, \
209-
{.alloc_cb = _alloc_cb}, \
209+
.cb = {.alloc = _alloc_cb}, \
210210
}
211211

212212
/**
@@ -230,7 +230,7 @@ void heap_listener_notify_resize(uintptr_t heap_id, void *old_heap_end, void *ne
230230
struct heap_listener name = { \
231231
.heap_id = _heap_id, \
232232
.event = HEAP_FREE, \
233-
{.free_cb = _free_cb}, \
233+
.cb = {.free = _free_cb}, \
234234
}
235235

236236
/**
@@ -254,7 +254,7 @@ void heap_listener_notify_resize(uintptr_t heap_id, void *old_heap_end, void *ne
254254
struct heap_listener name = { \
255255
.heap_id = _heap_id, \
256256
.event = HEAP_RESIZE, \
257-
{.resize_cb = _resize_cb}, \
257+
.cb = {.resize = _resize_cb}, \
258258
}
259259

260260
/** @} */

lib/heap/heap_listener.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ void heap_listener_notify_alloc(uintptr_t heap_id, void *mem, size_t bytes)
3434
k_spinlock_key_t key = k_spin_lock(&heap_listener_lock);
3535

3636
SYS_SLIST_FOR_EACH_CONTAINER(&heap_listener_list, listener, node) {
37-
if (listener->heap_id == heap_id && listener->alloc_cb != NULL &&
37+
if (listener->heap_id == heap_id && listener->cb.alloc != NULL &&
3838
listener->event == HEAP_ALLOC) {
39-
listener->alloc_cb(heap_id, mem, bytes);
39+
listener->cb.alloc(heap_id, mem, bytes);
4040
}
4141
}
4242

@@ -49,9 +49,9 @@ void heap_listener_notify_free(uintptr_t heap_id, void *mem, size_t bytes)
4949
k_spinlock_key_t key = k_spin_lock(&heap_listener_lock);
5050

5151
SYS_SLIST_FOR_EACH_CONTAINER(&heap_listener_list, listener, node) {
52-
if (listener->heap_id == heap_id && listener->free_cb != NULL &&
52+
if (listener->heap_id == heap_id && listener->cb.free != NULL &&
5353
listener->event == HEAP_FREE) {
54-
listener->free_cb(heap_id, mem, bytes);
54+
listener->cb.free(heap_id, mem, bytes);
5555
}
5656
}
5757

@@ -64,9 +64,9 @@ void heap_listener_notify_resize(uintptr_t heap_id, void *old_heap_end, void *ne
6464
k_spinlock_key_t key = k_spin_lock(&heap_listener_lock);
6565

6666
SYS_SLIST_FOR_EACH_CONTAINER(&heap_listener_list, listener, node) {
67-
if (listener->heap_id == heap_id && listener->resize_cb != NULL &&
67+
if (listener->heap_id == heap_id && listener->cb.resize != NULL &&
6868
listener->event == HEAP_RESIZE) {
69-
listener->resize_cb(heap_id, old_heap_end, new_heap_end);
69+
listener->cb.resize(heap_id, old_heap_end, new_heap_end);
7070
}
7171
}
7272

0 commit comments

Comments
 (0)