Skip to content

Commit 897553a

Browse files
teburdcarlescufi
authored andcommitted
logging: Remove hda log backend
The HDA log backend has been buggy for some time, and the fixes are well understood. The issue with HDA log as it is implemented today means there are concurrency and ISR issues where it can deadlock. The fixes are effectively dropping the usage of ipc to communicate status, using polling on the hda stream, and having a formatter per call context (cores + isr) when log mode immediate is enabled to fix log mangling. However it was found this had a lot of unintentional side effects that made it difficult to make progress on when it came to changes of the host side python tooling. Meanwhile the feature has sat unused for nearly a year. Remove it, and it can always be revisited in the future if something like it happens to be needed. Signed-off-by: Tom Burdick <[email protected]>
1 parent a0ac2fa commit 897553a

File tree

10 files changed

+1
-560
lines changed

10 files changed

+1
-560
lines changed

subsys/logging/Kconfig.formatting

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ config LOG_BACKEND_FORMAT_TIMESTAMP
166166
bool "Timestamp formatting in the backend"
167167
depends on LOG_BACKEND_UART || LOG_BACKEND_NATIVE_POSIX || LOG_BACKEND_RTT \
168168
|| LOG_BACKEND_SWO || LOG_BACKEND_XTENSA_SIM || LOG_BACKEND_FS \
169-
|| LOG_BACKEND_ADSP || LOG_BACKEND_ADSP_HDA || LOG_BACKEND_ADSP_MTRACE
169+
|| LOG_BACKEND_ADSP || LOG_BACKEND_ADSP_MTRACE
170170
default y
171171
help
172172
When enabled timestamp is formatted to hh:mm:ss:ms,us.

subsys/logging/backends/CMakeLists.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,6 @@ zephyr_sources_ifdef(
55
log_backend_adsp.c
66
)
77

8-
zephyr_sources_ifdef(
9-
CONFIG_LOG_BACKEND_ADSP_HDA
10-
log_backend_adsp_hda.c
11-
)
12-
138
zephyr_sources_ifdef(
149
CONFIG_LOG_BACKEND_ADSP_MTRACE
1510
log_backend_adsp_mtrace.c

subsys/logging/backends/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
menu "Backends"
55

66
rsource "Kconfig.adsp"
7-
rsource "Kconfig.adsp_hda"
87
rsource "Kconfig.adsp_mtrace"
98
rsource "Kconfig.ble"
109
rsource "Kconfig.efi_console"

subsys/logging/backends/Kconfig.adsp_hda

Lines changed: 0 additions & 52 deletions
This file was deleted.

0 commit comments

Comments
 (0)